From 047bc44032d5eb33defe4f5a2e9c6da6765602e3 Mon Sep 17 00:00:00 2001 From: Eric Rahm Date: Wed, 22 Oct 2025 17:08:38 -0700 Subject: [PATCH] refactor(core): Clean up exclude description (#11678) Co-authored-by: Jacob Richman --- .../core/src/services/fileDiscoveryService.ts | 7 ------ packages/core/src/tools/read-many-files.ts | 23 +++---------------- 2 files changed, 3 insertions(+), 27 deletions(-) diff --git a/packages/core/src/services/fileDiscoveryService.ts b/packages/core/src/services/fileDiscoveryService.ts index dbec5f1ffa..981e81127e 100644 --- a/packages/core/src/services/fileDiscoveryService.ts +++ b/packages/core/src/services/fileDiscoveryService.ts @@ -115,11 +115,4 @@ export class FileDiscoveryService { } return false; } - - /** - * Returns loaded patterns from .geminiignore - */ - getGeminiIgnorePatterns(): string[] { - return this.geminiIgnoreFilter?.getPatterns() ?? []; - } } diff --git a/packages/core/src/tools/read-many-files.ts b/packages/core/src/tools/read-many-files.ts index 5681647cb5..a437235b83 100644 --- a/packages/core/src/tools/read-many-files.ts +++ b/packages/core/src/tools/read-many-files.ts @@ -133,19 +133,12 @@ ${this.config.getTargetDir()} // Determine the final list of exclusion patterns exactly as in execute method const paramExcludes = this.params.exclude || []; const paramUseDefaultExcludes = this.params.useDefaultExcludes !== false; - const geminiIgnorePatterns = this.config - .getFileService() - .getGeminiIgnorePatterns(); const finalExclusionPatternsForDescription: string[] = paramUseDefaultExcludes - ? [ - ...getDefaultExcludes(this.config), - ...paramExcludes, - ...geminiIgnorePatterns, - ] - : [...paramExcludes, ...geminiIgnorePatterns]; + ? [...getDefaultExcludes(this.config), ...paramExcludes] + : [...paramExcludes]; - let excludeDesc = `Excluding: ${ + const excludeDesc = `Excluding: ${ finalExclusionPatternsForDescription.length > 0 ? `patterns like ${finalExclusionPatternsForDescription @@ -156,16 +149,6 @@ ${finalExclusionPatternsForDescription : 'none specified' }`; - // Add a note if .geminiignore patterns contributed to the final list of exclusions - if (geminiIgnorePatterns.length > 0) { - const geminiPatternsInEffect = geminiIgnorePatterns.filter((p) => - finalExclusionPatternsForDescription.includes(p), - ).length; - if (geminiPatternsInEffect > 0) { - excludeDesc += ` (includes ${geminiPatternsInEffect} from .geminiignore)`; - } - } - return `Will attempt to read and concatenate files ${pathDesc}. ${excludeDesc}. File encoding: ${DEFAULT_ENCODING}. Separator: "${DEFAULT_OUTPUT_SEPARATOR_FORMAT.replace( '{filePath}', 'path/to/file.ext',