MediaMetz/gemini-cli
1
0
Fork 0
mirror of https://github.com/google-gemini/gemini-cli.git synced 2026-05-12 12:54:07 -07:00
Code Issues Packages Projects Releases Wiki Activity

feat(shell): always include exit_code in subprocess_result XML

Browse Source
This commit is contained in:
Aishanee Shah
2026-02-17 23:07:43 +00:00
parent f8b3d14d26
commit 0643481cbd
2 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/core/src/tools/shell.test.ts
+3 -2
View File
@@ -687,13 +687,13 @@ describe('ShellTool', () => {
expect(result.llmContent).not.toContain('Directory:'); expect(result.llmContent).not.toContain('Directory:');
}); });
it('should not include Exit Code when command succeeds (exit code 0)', async () => { it('should include Exit Code when command succeeds (exit code 0)', async () => {
const invocation = shellTool.build({ command: 'echo hello' }); const invocation = shellTool.build({ command: 'echo hello' });
const promise = invocation.execute(mockAbortSignal); const promise = invocation.execute(mockAbortSignal);
resolveShellExecution({ output: 'hello', exitCode: 0 }); resolveShellExecution({ output: 'hello', exitCode: 0 });
const result = await promise; const result = await promise;
expect(result.llmContent).not.toContain('<exit_code>'); expect(result.llmContent).toContain('<exit_code>0</exit_code>');
}); });
it('should include Exit Code when command fails (non-zero exit code)', async () => { it('should include Exit Code when command fails (non-zero exit code)', async () => {
@@ -776,6 +776,7 @@ describe('ShellTool', () => {
// Should only contain subprocess_result and output // Should only contain subprocess_result and output
expect(result.llmContent).toContain('<subprocess_result>'); expect(result.llmContent).toContain('<subprocess_result>');
expect(result.llmContent).toContain('<output>hello</output>'); expect(result.llmContent).toContain('<output>hello</output>');
expect(result.llmContent).toContain('<exit_code>0</exit_code>');
}); });
}); });
packages/core/src/tools/shell.ts
+1 -1
View File
@@ -365,7 +365,7 @@ export class ShellToolInvocation extends BaseToolInvocation<
parts.push(`<error>${finalError}</error>`); parts.push(`<error>${finalError}</error>`);
} }
if (result.exitCode !== null && result.exitCode !== 0) { if (result.exitCode !== null) {
parts.push(`<exit_code>${result.exitCode}</exit_code>`); parts.push(`<exit_code>${result.exitCode}</exit_code>`);
} }