Harded code assist converter. (#18656)

packages/core/src/code_assist/converter.test.ts

@@ -331,6 +331,16 @@ describe('converter', () => {
       const genaiRes = fromGenerateContentResponse(codeAssistRes);
       expect(genaiRes.responseId).toBeUndefined();
     });
+
+    it('should handle missing response property gracefully', () => {
+      const invalidRes = {
+        traceId: 'some-trace-id',
+      } as unknown as CaGenerateContentResponse;
+
+      const genaiRes = fromGenerateContentResponse(invalidRes);
+      expect(genaiRes.responseId).toEqual('some-trace-id');
+      expect(genaiRes.candidates).toEqual([]);
+    });
   });
 
   describe('toContents', () => {

packages/core/src/code_assist/converter.ts

@@ -133,14 +133,18 @@ export function toGenerateContentRequest(
 export function fromGenerateContentResponse(
   res: CaGenerateContentResponse,
 ): GenerateContentResponse {
-  const inres = res.response;
   const out = new GenerateContentResponse();
-  out.candidates = inres.candidates;
+  out.responseId = res.traceId;
+  const inres = res.response;
+  if (!inres) {
+    out.candidates = [];
+    return out;
+  }
+  out.candidates = inres.candidates ?? [];
   out.automaticFunctionCallingHistory = inres.automaticFunctionCallingHistory;
   out.promptFeedback = inres.promptFeedback;
   out.usageMetadata = inres.usageMetadata;
   out.modelVersion = inres.modelVersion;
-  out.responseId = res.traceId;
   return out;
 }