MediaMetz/gemini-cli
1
0
Fork 0
mirror of https://github.com/google-gemini/gemini-cli.git synced 2026-04-21 18:44:30 -07:00
Code Issues Packages Projects Releases Wiki Activity

Log all user settings to enable measurement of experiment impacts (#11354)

Browse Source
This commit is contained in:
owenofbrien
2025-10-17 15:54:35 -05:00
committed by GitHub
parent d3bdbc6978
commit 08e87a59d5
3 changed files with 51 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/core/src/telemetry/clearcut-logger/clearcut-logger.test.ts
+4 -11
View File
@@ -37,7 +37,6 @@ import { AgentTerminateMode } from '../../agents/types.js';
import { GIT_COMMIT_INFO, CLI_VERSION } from '../../generated/git-commit.js';
import { UserAccountManager } from '../../utils/userAccountManager.js';
import { InstallationManager } from '../../utils/installationManager.js';
import { safeJsonStringify } from '../../utils/safeJsonStringify.js';
interface CustomMatchers<R = unknown> {
toHaveMetadataValue: ([key, value]: [EventMetadataKey, string]) => R;
@@ -260,15 +259,13 @@ describe('ClearcutLogger', () => {
const cli_version = CLI_VERSION;
const git_commit_hash = GIT_COMMIT_INFO;
const prompt_id = 'my-prompt-123';
const user_settings = safeJsonStringify([
{ smart_edit_enabled: true, model_router_enabled: false },
]);
// Setup logger with expected values
const { logger, loggerConfig } = setup({
lifetimeGoogleAccounts: google_accounts,
config: { sessionId: session_id },
});
vi.spyOn(loggerConfig, 'getContentGeneratorConfig').mockReturnValue({
authType: auth_type,
} as ContentGeneratorConfig);
@@ -315,7 +312,7 @@ describe('ClearcutLogger', () => {
},
{
gemini_cli_key: EventMetadataKey.GEMINI_CLI_USER_SETTINGS,
value: user_settings,
value: logger?.getConfigJson(),
},
]),
);
@@ -346,11 +343,7 @@ describe('ClearcutLogger', () => {
});
});
it('logs the value of config.useSmartEdit and config.useModelRouter', () => {
const user_settings = safeJsonStringify([
{ smart_edit_enabled: true, model_router_enabled: true },
]);
it('logs all user settings', () => {
const { logger } = setup({
config: { useSmartEdit: true, useModelRouter: true },
});
@@ -362,7 +355,7 @@ describe('ClearcutLogger', () => {
expect(event?.event_metadata[0]).toContainEqual({
gemini_cli_key: EventMetadataKey.GEMINI_CLI_USER_SETTINGS,
value: user_settings,
value: logger?.getConfigJson(),
});
});
packages/core/src/telemetry/clearcut-logger/clearcut-logger.ts
+11 -7
View File
@@ -42,7 +42,10 @@ import { EventMetadataKey } from './event-metadata-key.js';
import type { Config } from '../../config/config.js';
import { InstallationManager } from '../../utils/installationManager.js';
import { UserAccountManager } from '../../utils/userAccountManager.js';
import { safeJsonStringify } from '../../utils/safeJsonStringify.js';
import {
safeJsonStringify,
safeJsonStringifyBooleanValuesOnly,
} from '../../utils/safeJsonStringify.js';
import { FixedDeque } from 'mnemonist';
import { GIT_COMMIT_INFO, CLI_VERSION } from '../../generated/git-commit.js';
import {
@@ -1217,12 +1220,7 @@ export class ClearcutLogger {
},
{
gemini_cli_key: EventMetadataKey.GEMINI_CLI_USER_SETTINGS,
value: safeJsonStringify([
{
smart_edit_enabled: this.config?.getUseSmartEdit() ?? false,
model_router_enabled: this.config?.getUseModelRouter() ?? false,
},
]),
value: this.getConfigJson(),
},
];
return [...data, ...defaultLogMetadata];
@@ -1240,6 +1238,12 @@ export class ClearcutLogger {
}
}
getConfigJson() {
const configJson = safeJsonStringifyBooleanValuesOnly(this.config);
console.debug(configJson);
return safeJsonStringifyBooleanValuesOnly(this.config);
}
shutdown() {
this.logEndSessionEvent();
}