proper docker tagging for testing

This commit is contained in:
mkorwel
2025-07-01 15:20:41 -05:00
parent bad2b05e61
commit 0f543dc4a8
2 changed files with 6 additions and 2 deletions
+1
View File
@@ -23,6 +23,7 @@ steps:
entrypoint: 'npm' entrypoint: 'npm'
args: ['run', 'build:sandbox:fast'] args: ['run', 'build:sandbox:fast']
env: env:
- 'GEMINI_SANDBOX_IMAGE_TAG=$SHORT_SHA'
- 'GEMINI_SANDBOX=$_CONTAINER_TOOL' - 'GEMINI_SANDBOX=$_CONTAINER_TOOL'
# Step 7: Publish sandbox container image # Step 7: Publish sandbox container image
+5 -2
View File
@@ -123,13 +123,16 @@ function buildImage(imageName, dockerfile) {
readFileSync(join(process.cwd(), 'package.json'), 'utf-8'), readFileSync(join(process.cwd(), 'package.json'), 'utf-8'),
).version; ).version;
const imageTag = process.env.GEMINI_SANDBOX_IMAGE_TAG || imageName.split(':')[1];
const finalImageName = `${imageName.split(':')[0]}:${imageTag}`;
execSync( execSync(
`${buildCommand} ${ `${buildCommand} ${
process.env.BUILD_SANDBOX_FLAGS || '' process.env.BUILD_SANDBOX_FLAGS || ''
} --build-arg CLI_VERSION_ARG=${npmPackageVersion} -f "${dockerfile}" -t "${imageName}" .`, } --build-arg CLI_VERSION_ARG=${npmPackageVersion} -f "${dockerfile}" -t "${finalImageName}" .`,
{ stdio: buildStdout, shell: '/bin/bash' }, { stdio: buildStdout, shell: '/bin/bash' },
); );
console.log(`built ${imageName}`); console.log(`built ${finalImageName}`);
} }
if (baseImage && baseDockerfile) { if (baseImage && baseDockerfile) {