refactor(core): extract ExecutionLifecycleService for tool backgrounding (#21717)

This commit is contained in:
Adam Weidman
2026-03-12 00:03:54 -04:00
committed by GitHub
parent 949e85ca55
commit 10ab958378
13 changed files with 1580 additions and 802 deletions
+5 -4
View File
@@ -18,6 +18,7 @@ import {
Kind,
type ToolInvocation,
type ToolResult,
type BackgroundExecutionData,
type ToolCallConfirmationDetails,
type ToolExecuteConfirmationDetails,
type PolicyUpdateOptions,
@@ -150,7 +151,7 @@ export class ShellToolInvocation extends BaseToolInvocation<
signal: AbortSignal,
updateOutput?: (output: ToolLiveOutput) => void,
shellExecutionConfig?: ShellExecutionConfig,
setPidCallback?: (pid: number) => void,
setExecutionIdCallback?: (executionId: number) => void,
): Promise<ToolResult> {
const strippedCommand = stripShellWrapper(this.params.command);
@@ -281,8 +282,8 @@ export class ShellToolInvocation extends BaseToolInvocation<
);
if (pid) {
if (setPidCallback) {
setPidCallback(pid);
if (setExecutionIdCallback) {
setExecutionIdCallback(pid);
}
// If the model requested to run in the background, do so after a short delay.
@@ -324,7 +325,7 @@ export class ShellToolInvocation extends BaseToolInvocation<
}
}
let data: Record<string, unknown> | undefined;
let data: BackgroundExecutionData | undefined;
let llmContent = '';
let timeoutMessage = '';