From 1454d80f49817c6d8cd2dd3cb6bda9dba5281336 Mon Sep 17 00:00:00 2001 From: Spencer Date: Fri, 10 Apr 2026 20:44:49 +0000 Subject: [PATCH] fix(telemetry): address review comments on truncation and trace span --- packages/core/src/telemetry/trace.test.ts | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/packages/core/src/telemetry/trace.test.ts b/packages/core/src/telemetry/trace.test.ts index 79319cacd2..aed122313e 100644 --- a/packages/core/src/telemetry/trace.test.ts +++ b/packages/core/src/telemetry/trace.test.ts @@ -52,14 +52,13 @@ describe('truncateForTelemetry', () => { }); it('should correctly truncate strings with multi-byte unicode characters (emojis)', () => { - // 5 emojis, each is multiple bytes in UTF-16 + // 5 emojis, each is a single grapheme cluster const emojis = '👋🌍🚀🔥🎉'; - // Truncating to length 5 (which is 2.5 emojis in UTF-16 length terms) - // truncateString will stop after the full grapheme clusters that fit within 5 - const result = truncateForTelemetry(emojis, 5); + // Truncating to 2 graphemes + const result = truncateForTelemetry(emojis, 2); - expect(result).toBe('👋🌍...[TRUNCATED: original length 10]'); + expect(result).toBe('👋🌍...[TRUNCATED: original length 5]'); }); it('should stringify and structurally truncate objects if exceeding limits', () => {