Fix/windows pty crash (#12587)

Co-authored-by: LayorX <yor31117@gmail.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This commit is contained in:
Bryan Morgan
2025-11-05 11:53:03 -05:00
committed by GitHub
parent f51d74586c
commit 16113647de
8 changed files with 125 additions and 45 deletions
@@ -83,18 +83,21 @@ describe('WorkspaceContext with real filesystem', () => {
expect(directories).toHaveLength(2);
});
it('should handle symbolic links correctly', () => {
const realDir = path.join(tempDir, 'real');
fs.mkdirSync(realDir, { recursive: true });
const symlinkDir = path.join(tempDir, 'symlink-to-real');
fs.symlinkSync(realDir, symlinkDir, 'dir');
const workspaceContext = new WorkspaceContext(cwd);
workspaceContext.addDirectory(symlinkDir);
it.skipIf(os.platform() === 'win32')(
'should handle symbolic links correctly',
() => {
const realDir = path.join(tempDir, 'real');
fs.mkdirSync(realDir, { recursive: true });
const symlinkDir = path.join(tempDir, 'symlink-to-real');
fs.symlinkSync(realDir, symlinkDir, 'dir');
const workspaceContext = new WorkspaceContext(cwd);
workspaceContext.addDirectory(symlinkDir);
const directories = workspaceContext.getDirectories();
const directories = workspaceContext.getDirectories();
expect(directories).toEqual([cwd, realDir]);
});
expect(directories).toEqual([cwd, realDir]);
},
);
});
describe('path validation', () => {
@@ -158,7 +161,7 @@ describe('WorkspaceContext with real filesystem', () => {
);
});
describe('with symbolic link', () => {
describe.skipIf(os.platform() === 'win32')('with symbolic link', () => {
describe('in the workspace', () => {
let realDir: string;
let symlinkDir: string;