MediaMetz/gemini-cli
1
0
Fork 0
mirror of https://github.com/google-gemini/gemini-cli.git synced 2026-03-23 20:40:41 -07:00
Code Issues Packages Projects Releases Wiki Activity

fix(hooks): enable /hooks disable to reliably stop single hooks (#16804)

Browse Source
This commit is contained in:
Abhi
2026-01-16 19:28:36 -05:00
committed by GitHub
parent ee8d425603
commit 1998a713e2
4 changed files with 97 additions and 59 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
packages/cli/src/ui/commands/hooksCommand.test.ts
View File

@@ -22,6 +22,7 @@ describe('hooksCommand', () => {
let mockConfig: {
getHookSystem: ReturnType<typeof vi.fn>;
getEnableHooks: ReturnType<typeof vi.fn>;
updateDisabledHooks: ReturnType<typeof vi.fn>;
};
let mockSettings: {
merged: {
@@ -51,6 +52,7 @@ describe('hooksCommand', () => {
mockConfig = {
getHookSystem: vi.fn().mockReturnValue(mockHookSystem),
getEnableHooks: vi.fn().mockReturnValue(true),
updateDisabledHooks: vi.fn(),
};
// Create mock settings
@@ -429,7 +431,7 @@ describe('hooksCommand', () => {
});
});
it('should return info when hook is already disabled', async () => {
it('should synchronize with hook system even if hook is already in disabled list', async () => {
// Update the context's settings with the hook already disabled
mockContext.services.settings.merged.hooks.disabled = ['test-hook'];
@@ -443,11 +445,15 @@ describe('hooksCommand', () => {
const result = await disableCmd.action(mockContext, 'test-hook');
expect(mockContext.services.settings.setValue).not.toHaveBeenCalled();
expect(mockHookSystem.setHookEnabled).not.toHaveBeenCalled();
expect(mockHookSystem.setHookEnabled).toHaveBeenCalledWith(
'test-hook',
false,
);
expect(mockConfig.updateDisabledHooks).toHaveBeenCalled();
expect(result).toEqual({
type: 'message',
messageType: 'info',
content: 'Hook "test-hook" is already disabled.',
content: 'Hook "test-hook" disabled successfully.',
});
});