From 1a722ead96929d6659004d0be383592a06b46008 Mon Sep 17 00:00:00 2001 From: Spencer Date: Fri, 20 Mar 2026 13:22:11 +0000 Subject: [PATCH] fix: address PR review feedback and test snapshots --- .../messages/RedirectionConfirmation.test.tsx | 9 ++-- .../ToolConfirmationMessage.test.tsx.snap | 42 +++++++++++++++++++ 2 files changed, 46 insertions(+), 5 deletions(-) diff --git a/packages/cli/src/ui/components/messages/RedirectionConfirmation.test.tsx b/packages/cli/src/ui/components/messages/RedirectionConfirmation.test.tsx index d790230074..2c58306410 100644 --- a/packages/cli/src/ui/components/messages/RedirectionConfirmation.test.tsx +++ b/packages/cli/src/ui/components/messages/RedirectionConfirmation.test.tsx @@ -6,12 +6,11 @@ import { describe, it, expect, beforeAll, vi } from 'vitest'; import { ToolConfirmationMessage } from './ToolConfirmationMessage.js'; -import { - type SerializableConfirmationDetails, - type Config, - initializeShellParsers, +import type { + SerializableConfirmationDetails, + Config, } from '@google/gemini-cli-core'; - +import { initializeShellParsers } from '@google/gemini-cli-core'; import { renderWithProviders } from '../../../test-utils/render.js'; describe('ToolConfirmationMessage Redirection', () => { diff --git a/packages/cli/src/ui/components/messages/__snapshots__/ToolConfirmationMessage.test.tsx.snap b/packages/cli/src/ui/components/messages/__snapshots__/ToolConfirmationMessage.test.tsx.snap index 085d0bc445..2ec0d720b7 100644 --- a/packages/cli/src/ui/components/messages/__snapshots__/ToolConfirmationMessage.test.tsx.snap +++ b/packages/cli/src/ui/components/messages/__snapshots__/ToolConfirmationMessage.test.tsx.snap @@ -1,5 +1,47 @@ // Vitest Snapshot v1, https://vitest.dev/guide/snapshot.html +exports[`ToolConfirmationMessage > Auto-approve checkbox for exec tools > hides permanent approval option for 'edit commands in DEFAULT mode' 1`] = ` +"mkdir test +Allow execution of: 'mkdir'? + +● 1. Allow once + 2. Allow for this session + 3. No, suggest changes (esc) +" +`; + +exports[`ToolConfirmationMessage > Auto-approve checkbox for exec tools > hides permanent approval option for 'unsafe commands' 1`] = ` +"rm -rf / +Allow execution of: 'rm'? + +● 1. Allow once + 2. Allow for this session + 3. No, suggest changes (esc) +" +`; + +exports[`ToolConfirmationMessage > Auto-approve checkbox for exec tools > shows permanent approval option for 'edit commands in AUTO_EDIT mode' 1`] = ` +"mkdir test +Allow execution of: 'mkdir'? + +● 1. Allow once + 2. Allow for this session + 3. Allow this command for all future sessions + 4. No, suggest changes (esc) +" +`; + +exports[`ToolConfirmationMessage > Auto-approve checkbox for exec tools > shows permanent approval option for 'safe commands' 1`] = ` +"ls -la +Allow execution of: 'ls'? + +● 1. Allow once + 2. Allow for this session + 3. Allow this command for all future sessions + 4. No, suggest changes (esc) +" +`; + exports[`ToolConfirmationMessage > enablePermanentToolApproval setting > should show "Allow for all future sessions" when trusted 1`] = ` "╭──────────────────────────────────────────────────────────────────────────────╮ │ │