MediaMetz/gemini-cli
1
0
Fork 0
mirror of https://github.com/google-gemini/gemini-cli.git synced 2026-05-12 12:54:07 -07:00
Code Issues Packages Projects Releases Wiki Activity

fix(core): explicitly pass messageBus to policy engine for MCP tool saves (#22255)

Browse Source
This commit is contained in:
Abhi
2026-03-12 21:31:13 -04:00
committed by GitHub
parent 97bc3f28c5
commit 1d2585dba6
8 changed files with 43 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/core/src/scheduler/policy.test.ts
+15 -4
View File
@@ -227,6 +227,7 @@ describe('policy.ts', () => {
ToolConfirmationOutcome.ProceedAlways,
undefined,
mockConfig,
mockMessageBus,
);
expect(mockConfig.setApprovalMode).toHaveBeenCalledWith(
@@ -254,6 +255,7 @@ describe('policy.ts', () => {
ToolConfirmationOutcome.ProceedAlways,
undefined,
mockConfig,
mockMessageBus,
);
expect(mockMessageBus.publish).toHaveBeenCalledWith(
@@ -286,6 +288,7 @@ describe('policy.ts', () => {
ToolConfirmationOutcome.ProceedAlwaysAndSave,
undefined,
mockConfig,
mockMessageBus,
);
expect(mockMessageBus.publish).toHaveBeenCalledWith(
@@ -324,6 +327,7 @@ describe('policy.ts', () => {
ToolConfirmationOutcome.ProceedAlways,
details,
mockConfig,
mockMessageBus,
);
expect(mockMessageBus.publish).toHaveBeenCalledWith(
@@ -362,12 +366,13 @@ describe('policy.ts', () => {
ToolConfirmationOutcome.ProceedAlwaysServer,
details,
mockConfig,
mockMessageBus,
);
expect(mockMessageBus.publish).toHaveBeenCalledWith(
expect.objectContaining({
type: MessageBusType.UPDATE_POLICY,
toolName: 'my-server__*',
toolName: 'mcp_my-server_*',
mcpName: 'my-server',
persist: false,
}),
@@ -393,6 +398,7 @@ describe('policy.ts', () => {
ToolConfirmationOutcome.ProceedOnce,
undefined,
mockConfig,
mockMessageBus,
);
expect(mockMessageBus.publish).not.toHaveBeenCalled();
@@ -418,6 +424,7 @@ describe('policy.ts', () => {
ToolConfirmationOutcome.Cancel,
undefined,
mockConfig,
mockMessageBus,
);
expect(mockMessageBus.publish).not.toHaveBeenCalled();
@@ -442,6 +449,7 @@ describe('policy.ts', () => {
ToolConfirmationOutcome.ModifyWithEditor,
undefined,
mockConfig,
mockMessageBus,
);
expect(mockMessageBus.publish).not.toHaveBeenCalled();
@@ -474,6 +482,7 @@ describe('policy.ts', () => {
ToolConfirmationOutcome.ProceedAlwaysTool,
details,
mockConfig,
mockMessageBus,
);
expect(mockMessageBus.publish).toHaveBeenCalledWith(
@@ -513,6 +522,7 @@ describe('policy.ts', () => {
ToolConfirmationOutcome.ProceedAlways,
details,
mockConfig,
mockMessageBus,
);
expect(mockMessageBus.publish).toHaveBeenCalledWith(
@@ -554,6 +564,7 @@ describe('policy.ts', () => {
ToolConfirmationOutcome.ProceedAlwaysAndSave,
details,
mockConfig,
mockMessageBus,
);
expect(mockMessageBus.publish).toHaveBeenCalledWith(
@@ -585,8 +596,8 @@ describe('policy.ts', () => {
undefined,
{
config: mockConfig,
messageBus: mockMessageBus,
} as unknown as AgentLoopContext,
mockMessageBus,
);
expect(mockMessageBus.publish).toHaveBeenCalledWith(
@@ -615,8 +626,8 @@ describe('policy.ts', () => {
undefined,
{
config: mockConfig,
messageBus: mockMessageBus,
} as unknown as AgentLoopContext,
mockMessageBus,
);
expect(mockMessageBus.publish).toHaveBeenCalledWith(
@@ -653,8 +664,8 @@ describe('policy.ts', () => {
details,
{
config: mockConfig,
messageBus: mockMessageBus,
} as unknown as AgentLoopContext,
mockMessageBus,
);
expect(mockMessageBus.publish).toHaveBeenCalledWith(