MediaMetz/gemini-cli
1
0
Fork 0
mirror of https://github.com/google-gemini/gemini-cli.git synced 2026-07-10 10:00:53 -07:00
Code Issues Packages Projects Releases Wiki Activity

refactor(core): consolidate execute() arguments into ExecuteOptions (#25101)

Browse Source
This commit is contained in:
Michael Bleigh
2026-04-10 10:11:17 -07:00
committed by GitHub
parent 0d547919ee
commit 1d9cd8f8ed
69 changed files with 849 additions and 527 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/core/src/tools/write-file.test.ts
+11 -11
View File
@@ -672,7 +672,7 @@ describe('WriteFileTool', () => {
const params = { file_path: relativePath, content };
const invocation = tool.build(params);
const result = await invocation.execute(abortSignal);
const result = await invocation.execute({ abortSignal });
expect(result.llmContent).toMatch(
/Successfully created and wrote to new file/,
@@ -693,7 +693,7 @@ describe('WriteFileTool', () => {
});
const invocation = tool.build(params);
const result = await invocation.execute(abortSignal);
const result = await invocation.execute({ abortSignal });
expect(result.llmContent).toContain('Error checking existing file');
expect(result.returnDisplay).toMatch(
/Error checking existing file: Simulated read error for execute/,
@@ -718,7 +718,7 @@ describe('WriteFileTool', () => {
await confirmExecution(invocation);
const result = await invocation.execute(abortSignal);
const result = await invocation.execute({ abortSignal });
expect(mockEnsureCorrectFileContent).toHaveBeenCalledWith(
proposedContent,
@@ -763,7 +763,7 @@ describe('WriteFileTool', () => {
await confirmExecution(invocation);
const result = await invocation.execute(abortSignal);
const result = await invocation.execute({ abortSignal });
expect(mockEnsureCorrectFileContent).toHaveBeenCalledWith(
proposedContent,
@@ -796,7 +796,7 @@ describe('WriteFileTool', () => {
await confirmExecution(invocation);
await invocation.execute(abortSignal);
await invocation.execute({ abortSignal });
expect(fs.existsSync(dirPath)).toBe(true);
expect(fs.statSync(dirPath).isDirectory()).toBe(true);
@@ -833,7 +833,7 @@ describe('WriteFileTool', () => {
...(modified_by_user !== undefined && { modified_by_user }),
};
const invocation = tool.build(params);
const result = await invocation.execute(abortSignal);
const result = await invocation.execute({ abortSignal });
if (shouldIncludeMessage) {
expect(result.llmContent).toMatch(/User modified the `content`/);
@@ -851,7 +851,7 @@ describe('WriteFileTool', () => {
const params = { file_path: filePath, content };
const invocation = tool.build(params);
const result = await invocation.execute(abortSignal);
const result = await invocation.execute({ abortSignal });
expect(result.llmContent).toContain('Here is the updated code:');
expect(result.llmContent).toContain(content);
@@ -878,7 +878,7 @@ describe('WriteFileTool', () => {
await confirmDetails.onConfirm(ToolConfirmationOutcome.ProceedOnce);
}
const result = await invocation.execute(abortSignal);
const result = await invocation.execute({ abortSignal });
expect(result.llmContent).toContain('Here is the updated code:');
// Should contain the modified line
@@ -999,7 +999,7 @@ describe('WriteFileTool', () => {
const params = { file_path: filePath, content };
const invocation = tool.build(params);
const result = await invocation.execute(abortSignal);
const result = await invocation.execute({ abortSignal });
expect(result.error?.type).toBe(errorType);
const errorSuffix = errorCode ? ` (${errorCode})` : '';
@@ -1089,7 +1089,7 @@ describe('WriteFileTool', () => {
const params = { file_path: filePath, content };
const invocation = tool.build(params);
const result = await invocation.execute(abortSignal);
const result = await invocation.execute({ abortSignal });
expect(discoverJitContext).toHaveBeenCalled();
expect(result.llmContent).toContain('Newly Discovered Project Context');
@@ -1106,7 +1106,7 @@ describe('WriteFileTool', () => {
const params = { file_path: filePath, content };
const invocation = tool.build(params);
const result = await invocation.execute(abortSignal);
const result = await invocation.execute({ abortSignal });
expect(result.llmContent).not.toContain(
'Newly Discovered Project Context',