mirror of
https://github.com/google-gemini/gemini-cli.git
synced 2026-03-16 09:01:17 -07:00
Remove deprecated inline thinking setting
This commit is contained in:
@@ -373,16 +373,6 @@ const SETTINGS_SCHEMA = {
|
||||
description: 'Hide the window title bar',
|
||||
showInDialog: true,
|
||||
},
|
||||
showInlineThinking: {
|
||||
type: 'boolean',
|
||||
label: 'Show Inline Thinking',
|
||||
category: 'UI',
|
||||
requiresRestart: false,
|
||||
default: false,
|
||||
description:
|
||||
'Show model thinking summaries inline in the conversation (deprecated; prefer the specific thinking modes).',
|
||||
showInDialog: false,
|
||||
},
|
||||
showInlineThinkingFull: {
|
||||
type: 'boolean',
|
||||
label: 'Show Inline Thinking (Full)',
|
||||
|
||||
@@ -19,7 +19,8 @@ vi.mock('../contexts/SettingsContext.js', async () => {
|
||||
useSettings: () => ({
|
||||
merged: {
|
||||
ui: {
|
||||
showInlineThinking: false,
|
||||
showInlineThinkingFull: false,
|
||||
showInlineThinkingSummary: false,
|
||||
},
|
||||
},
|
||||
}),
|
||||
|
||||
@@ -16,7 +16,6 @@ vi.mock('../contexts/SettingsContext.js', () => ({
|
||||
useSettings: () => ({
|
||||
merged: {
|
||||
ui: {
|
||||
showInlineThinking: false,
|
||||
showInlineThinkingFull: false,
|
||||
showInlineThinkingSummary: false,
|
||||
},
|
||||
|
||||
@@ -82,6 +82,17 @@ import path from 'node:path';
|
||||
|
||||
const MAX_THOUGHT_SUMMARY_LENGTH = 140;
|
||||
|
||||
function splitGraphemes(value: string): string[] {
|
||||
if (typeof Intl !== 'undefined' && 'Segmenter' in Intl) {
|
||||
const segmenter = new Intl.Segmenter(undefined, {
|
||||
granularity: 'grapheme',
|
||||
});
|
||||
return Array.from(segmenter.segment(value), (segment) => segment.segment);
|
||||
}
|
||||
|
||||
return Array.from(value);
|
||||
}
|
||||
|
||||
function summarizeThought(thought: ThoughtSummary): ThoughtSummary {
|
||||
const subject = thought.subject.trim();
|
||||
if (subject) {
|
||||
@@ -93,12 +104,14 @@ function summarizeThought(thought: ThoughtSummary): ThoughtSummary {
|
||||
return { subject: '', description: '' };
|
||||
}
|
||||
|
||||
if (description.length <= MAX_THOUGHT_SUMMARY_LENGTH) {
|
||||
const descriptionGraphemes = splitGraphemes(description);
|
||||
if (descriptionGraphemes.length <= MAX_THOUGHT_SUMMARY_LENGTH) {
|
||||
return { subject: description, description: '' };
|
||||
}
|
||||
|
||||
const trimmed = description
|
||||
const trimmed = descriptionGraphemes
|
||||
.slice(0, MAX_THOUGHT_SUMMARY_LENGTH - 3)
|
||||
.join('')
|
||||
.trimEnd();
|
||||
return { subject: `${trimmed}...`, description: '' };
|
||||
}
|
||||
|
||||
@@ -21,9 +21,5 @@ export function getInlineThinkingMode(
|
||||
return 'summary';
|
||||
}
|
||||
|
||||
if (ui?.showInlineThinking) {
|
||||
return 'full';
|
||||
}
|
||||
|
||||
return 'off';
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user