MediaMetz/gemini-cli
1
0
Fork 0
mirror of https://github.com/google-gemini/gemini-cli.git synced 2026-05-13 05:12:55 -07:00
Code Issues Packages Projects Releases Wiki Activity

fix: correct redirect count increment in fetchJson (#24896)

Browse Source 
Co-authored-by: Tommaso Sciortino <sciortino@gmail.com>
This commit is contained in:
Kevin Zhao
2026-04-14 04:45:52 +08:00
committed by GitHub
parent 050c30330e
commit 24f9ec51d2
2 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/cli/src/config/extensions/github_fetch.test.ts
+2
View File
@@ -62,6 +62,7 @@ describe('fetchJson', () => {
const res = new EventEmitter() as IncomingMessage; const res = new EventEmitter() as IncomingMessage;
res.statusCode = 302; res.statusCode = 302;
res.headers = { location: 'https://example.com/final' }; res.headers = { location: 'https://example.com/final' };
res.resume = vi.fn();
(callback as (res: IncomingMessage) => void)(res); (callback as (res: IncomingMessage) => void)(res);
res.emit('end'); res.emit('end');
return new EventEmitter() as ClientRequest; return new EventEmitter() as ClientRequest;
@@ -85,6 +86,7 @@ describe('fetchJson', () => {
const res = new EventEmitter() as IncomingMessage; const res = new EventEmitter() as IncomingMessage;
res.statusCode = 301; res.statusCode = 301;
res.headers = { location: 'https://example.com/final-permanent' }; res.headers = { location: 'https://example.com/final-permanent' };
res.resume = vi.fn();
(callback as (res: IncomingMessage) => void)(res); (callback as (res: IncomingMessage) => void)(res);
res.emit('end'); res.emit('end');
return new EventEmitter() as ClientRequest; return new EventEmitter() as ClientRequest;
packages/cli/src/config/extensions/github_fetch.ts
+5 -1
View File
@@ -31,7 +31,11 @@ export async function fetchJson<T>(
if (!res.headers.location) { if (!res.headers.location) {
return reject(new Error('No location header in redirect response')); return reject(new Error('No location header in redirect response'));
} }
fetchJson<T>(res.headers.location, redirectCount++) res.resume();
fetchJson<T>(
new URL(res.headers.location, url).toString(),
redirectCount + 1,
)
.then(resolve) .then(resolve)
.catch(reject); .catch(reject);
return; return;