Defensive coding to reduce the risk of Maximum update depth errors (#20940)

2026-07-13 19:40:28 -07:00 · 2026-03-03 22:32:05 -08:00
parent 6b8b62526b
commit 268d51df6b
4 changed files with 122 additions and 25 deletions
@@ -96,12 +96,15 @@ export const MaxSizedBox: React.FC<MaxSizedBoxProps> = ({
    } else {
      removeOverflowingId?.(id);
    }
-
-    return () => {
-      removeOverflowingId?.(id);
-    };
  }, [id, totalHiddenLines, addOverflowingId, removeOverflowingId]);

+  useEffect(
+    () => () => {
+      removeOverflowingId?.(id);
+    },
+    [id, removeOverflowingId],
+  );
+
  if (effectiveMaxHeight === undefined) {
    return (
      <Box flexDirection="column" width={maxWidth}>