feat(core): add skill patching support with /memory inbox integration (#25148)

packages/cli/src/ui/components/SkillInboxDialog.test.tsx

@@ -5,12 +5,16 @@
  */
 
 import { act } from 'react';
-import { beforeEach, describe, expect, it, vi } from 'vitest';
-import type { Config, InboxSkill } from '@google/gemini-cli-core';
+import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest';
+import type { Config, InboxSkill, InboxPatch } from '@google/gemini-cli-core';
 import {
   dismissInboxSkill,
   listInboxSkills,
+  listInboxPatches,
   moveInboxSkill,
+  applyInboxPatch,
+  dismissInboxPatch,
+  isProjectSkillPatchTarget,
 } from '@google/gemini-cli-core';
 import { waitFor } from '../../test-utils/async.js';
 import { renderWithProviders } from '../../test-utils/render.js';
@@ -24,7 +28,11 @@ vi.mock('@google/gemini-cli-core', async (importOriginal) => {
     ...original,
     dismissInboxSkill: vi.fn(),
     listInboxSkills: vi.fn(),
+    listInboxPatches: vi.fn(),
     moveInboxSkill: vi.fn(),
+    applyInboxPatch: vi.fn(),
+    dismissInboxPatch: vi.fn(),
+    isProjectSkillPatchTarget: vi.fn(),
     getErrorMessage: vi.fn((error: unknown) =>
       error instanceof Error ? error.message : String(error),
     ),
@@ -32,20 +40,108 @@ vi.mock('@google/gemini-cli-core', async (importOriginal) => {
 });
 
 const mockListInboxSkills = vi.mocked(listInboxSkills);
+const mockListInboxPatches = vi.mocked(listInboxPatches);
 const mockMoveInboxSkill = vi.mocked(moveInboxSkill);
 const mockDismissInboxSkill = vi.mocked(dismissInboxSkill);
+const mockApplyInboxPatch = vi.mocked(applyInboxPatch);
+const mockDismissInboxPatch = vi.mocked(dismissInboxPatch);
+const mockIsProjectSkillPatchTarget = vi.mocked(isProjectSkillPatchTarget);
 
 const inboxSkill: InboxSkill = {
   dirName: 'inbox-skill',
   name: 'Inbox Skill',
   description: 'A test skill',
+  content:
+    '---\nname: Inbox Skill\ndescription: A test skill\n---\n\n## Procedure\n1. Do the thing\n',
   extractedAt: '2025-01-15T10:00:00Z',
 };
 
+const inboxPatch: InboxPatch = {
+  fileName: 'update-docs.patch',
+  name: 'update-docs',
+  entries: [
+    {
+      targetPath: '/home/user/.gemini/skills/docs-writer/SKILL.md',
+      diffContent: [
+        '--- /home/user/.gemini/skills/docs-writer/SKILL.md',
+        '+++ /home/user/.gemini/skills/docs-writer/SKILL.md',
+        '@@ -1,3 +1,4 @@',
+        ' line1',
+        ' line2',
+        '+line2.5',
+        ' line3',
+      ].join('\n'),
+    },
+  ],
+  extractedAt: '2025-01-20T14:00:00Z',
+};
+
+const workspacePatch: InboxPatch = {
+  fileName: 'workspace-update.patch',
+  name: 'workspace-update',
+  entries: [
+    {
+      targetPath: '/repo/.gemini/skills/docs-writer/SKILL.md',
+      diffContent: [
+        '--- /repo/.gemini/skills/docs-writer/SKILL.md',
+        '+++ /repo/.gemini/skills/docs-writer/SKILL.md',
+        '@@ -1,1 +1,2 @@',
+        ' line1',
+        '+line2',
+      ].join('\n'),
+    },
+  ],
+};
+
+const multiSectionPatch: InboxPatch = {
+  fileName: 'multi-section.patch',
+  name: 'multi-section',
+  entries: [
+    {
+      targetPath: '/home/user/.gemini/skills/docs-writer/SKILL.md',
+      diffContent: [
+        '--- /home/user/.gemini/skills/docs-writer/SKILL.md',
+        '+++ /home/user/.gemini/skills/docs-writer/SKILL.md',
+        '@@ -1,1 +1,2 @@',
+        ' line1',
+        '+line2',
+      ].join('\n'),
+    },
+    {
+      targetPath: '/home/user/.gemini/skills/docs-writer/SKILL.md',
+      diffContent: [
+        '--- /home/user/.gemini/skills/docs-writer/SKILL.md',
+        '+++ /home/user/.gemini/skills/docs-writer/SKILL.md',
+        '@@ -3,1 +4,2 @@',
+        ' line3',
+        '+line4',
+      ].join('\n'),
+    },
+  ],
+};
+
+const windowsGlobalPatch: InboxPatch = {
+  fileName: 'windows-update.patch',
+  name: 'windows-update',
+  entries: [
+    {
+      targetPath: 'C:\\Users\\sandy\\.gemini\\skills\\docs-writer\\SKILL.md',
+      diffContent: [
+        '--- C:\\Users\\sandy\\.gemini\\skills\\docs-writer\\SKILL.md',
+        '+++ C:\\Users\\sandy\\.gemini\\skills\\docs-writer\\SKILL.md',
+        '@@ -1,1 +1,2 @@',
+        ' line1',
+        '+line2',
+      ].join('\n'),
+    },
+  ],
+};
+
 describe('SkillInboxDialog', () => {
   beforeEach(() => {
     vi.clearAllMocks();
     mockListInboxSkills.mockResolvedValue([inboxSkill]);
+    mockListInboxPatches.mockResolvedValue([]);
     mockMoveInboxSkill.mockResolvedValue({
       success: true,
       message: 'Moved "inbox-skill" to ~/.gemini/skills.',
@@ -54,6 +150,30 @@ describe('SkillInboxDialog', () => {
       success: true,
       message: 'Dismissed "inbox-skill" from inbox.',
     });
+    mockApplyInboxPatch.mockResolvedValue({
+      success: true,
+      message: 'Applied patch to 1 file.',
+    });
+    mockDismissInboxPatch.mockResolvedValue({
+      success: true,
+      message: 'Dismissed "update-docs.patch" from inbox.',
+    });
+    mockIsProjectSkillPatchTarget.mockImplementation(
+      async (targetPath: string, config: Config) => {
+        const projectSkillsDir = config.storage
+          ?.getProjectSkillsDir?.()
+          ?.replaceAll('\\', '/')
+          ?.replace(/\/+$/, '');
+
+        return projectSkillsDir
+          ? targetPath.replaceAll('\\', '/').startsWith(projectSkillsDir)
+          : false;
+      },
+    );
+  });
+
+  afterEach(() => {
+    vi.unstubAllEnvs();
   });
 
   it('disables the project destination when the workspace is untrusted', async () => {
@@ -75,6 +195,17 @@ describe('SkillInboxDialog', () => {
       expect(lastFrame()).toContain('Inbox Skill');
     });
 
+    // Select skill → lands on preview
+    await act(async () => {
+      stdin.write('\r');
+      await waitUntilReady();
+    });
+
+    await waitFor(() => {
+      expect(lastFrame()).toContain('Review new skill');
+    });
+
+    // Select "Move" → lands on destination chooser
     await act(async () => {
       stdin.write('\r');
       await waitUntilReady();
@@ -86,22 +217,6 @@ describe('SkillInboxDialog', () => {
       expect(frame).toContain('unavailable until this workspace is trusted');
     });
 
-    await act(async () => {
-      stdin.write('\x1b[B');
-      await waitUntilReady();
-    });
-
-    await act(async () => {
-      stdin.write('\r');
-      await waitUntilReady();
-    });
-
-    await waitFor(() => {
-      expect(mockDismissInboxSkill).toHaveBeenCalledWith(config, 'inbox-skill');
-    });
-    expect(mockMoveInboxSkill).not.toHaveBeenCalled();
-    expect(onReloadSkills).not.toHaveBeenCalled();
-
     unmount();
   });
 
@@ -125,11 +240,19 @@ describe('SkillInboxDialog', () => {
       expect(lastFrame()).toContain('Inbox Skill');
     });
 
+    // Select skill → preview
     await act(async () => {
       stdin.write('\r');
       await waitUntilReady();
     });
 
+    // Select "Move" → destination chooser
+    await act(async () => {
+      stdin.write('\r');
+      await waitUntilReady();
+    });
+
+    // Select "Global" → triggers move
     await act(async () => {
       stdin.write('\r');
       await waitUntilReady();
@@ -165,11 +288,19 @@ describe('SkillInboxDialog', () => {
       expect(lastFrame()).toContain('Inbox Skill');
     });
 
+    // Select skill → preview
     await act(async () => {
       stdin.write('\r');
       await waitUntilReady();
     });
 
+    // Select "Move" → destination chooser
+    await act(async () => {
+      stdin.write('\r');
+      await waitUntilReady();
+    });
+
+    // Select "Global" → triggers move
     await act(async () => {
       stdin.write('\r');
       await waitUntilReady();
@@ -184,4 +315,346 @@ describe('SkillInboxDialog', () => {
 
     unmount();
   });
+
+  describe('patch support', () => {
+    it('shows patches alongside skills with section headers', async () => {
+      mockListInboxPatches.mockResolvedValue([inboxPatch]);
+
+      const config = {
+        isTrustedFolder: vi.fn().mockReturnValue(true),
+        storage: {
+          getProjectSkillsDir: vi.fn().mockReturnValue('/repo/.gemini/skills'),
+        },
+      } as unknown as Config;
+      const { lastFrame, unmount } = await act(async () =>
+        renderWithProviders(
+          <SkillInboxDialog
+            config={config}
+            onClose={vi.fn()}
+            onReloadSkills={vi.fn().mockResolvedValue(undefined)}
+          />,
+        ),
+      );
+
+      await waitFor(() => {
+        const frame = lastFrame();
+        expect(frame).toContain('New Skills');
+        expect(frame).toContain('Inbox Skill');
+        expect(frame).toContain('Skill Updates');
+        expect(frame).toContain('update-docs');
+      });
+
+      unmount();
+    });
+
+    it('shows diff preview when a patch is selected', async () => {
+      mockListInboxSkills.mockResolvedValue([]);
+      mockListInboxPatches.mockResolvedValue([inboxPatch]);
+
+      const config = {
+        isTrustedFolder: vi.fn().mockReturnValue(true),
+        storage: {
+          getProjectSkillsDir: vi.fn().mockReturnValue('/repo/.gemini/skills'),
+        },
+      } as unknown as Config;
+      const { lastFrame, stdin, unmount, waitUntilReady } = await act(
+        async () =>
+          renderWithProviders(
+            <SkillInboxDialog
+              config={config}
+              onClose={vi.fn()}
+              onReloadSkills={vi.fn().mockResolvedValue(undefined)}
+            />,
+          ),
+      );
+
+      await waitFor(() => {
+        expect(lastFrame()).toContain('update-docs');
+      });
+
+      // Select the patch
+      await act(async () => {
+        stdin.write('\r');
+        await waitUntilReady();
+      });
+
+      await waitFor(() => {
+        const frame = lastFrame();
+        expect(frame).toContain('Review changes before applying');
+        expect(frame).toContain('Apply');
+        expect(frame).toContain('Dismiss');
+      });
+
+      unmount();
+    });
+
+    it('applies a patch when Apply is selected', async () => {
+      mockListInboxSkills.mockResolvedValue([]);
+      mockListInboxPatches.mockResolvedValue([inboxPatch]);
+
+      const config = {
+        isTrustedFolder: vi.fn().mockReturnValue(true),
+        storage: {
+          getProjectSkillsDir: vi.fn().mockReturnValue('/repo/.gemini/skills'),
+        },
+      } as unknown as Config;
+      const onReloadSkills = vi.fn().mockResolvedValue(undefined);
+      const { stdin, unmount, waitUntilReady } = await act(async () =>
+        renderWithProviders(
+          <SkillInboxDialog
+            config={config}
+            onClose={vi.fn()}
+            onReloadSkills={onReloadSkills}
+          />,
+        ),
+      );
+
+      await waitFor(() => {
+        expect(mockListInboxPatches).toHaveBeenCalled();
+      });
+
+      // Select the patch
+      await act(async () => {
+        stdin.write('\r');
+        await waitUntilReady();
+      });
+
+      // Select "Apply"
+      await act(async () => {
+        stdin.write('\r');
+        await waitUntilReady();
+      });
+
+      await waitFor(() => {
+        expect(mockApplyInboxPatch).toHaveBeenCalledWith(
+          config,
+          'update-docs.patch',
+        );
+      });
+      expect(onReloadSkills).toHaveBeenCalled();
+
+      unmount();
+    });
+
+    it('disables Apply for workspace patches in an untrusted workspace', async () => {
+      mockListInboxSkills.mockResolvedValue([]);
+      mockListInboxPatches.mockResolvedValue([workspacePatch]);
+
+      const config = {
+        isTrustedFolder: vi.fn().mockReturnValue(false),
+        storage: {
+          getProjectSkillsDir: vi.fn().mockReturnValue('/repo/.gemini/skills'),
+        },
+      } as unknown as Config;
+      const { lastFrame, stdin, unmount, waitUntilReady } = await act(
+        async () =>
+          renderWithProviders(
+            <SkillInboxDialog
+              config={config}
+              onClose={vi.fn()}
+              onReloadSkills={vi.fn().mockResolvedValue(undefined)}
+            />,
+          ),
+      );
+
+      await waitFor(() => {
+        expect(lastFrame()).toContain('workspace-update');
+      });
+
+      await act(async () => {
+        stdin.write('\r');
+        await waitUntilReady();
+      });
+
+      await waitFor(() => {
+        const frame = lastFrame();
+        expect(frame).toContain('Apply');
+        expect(frame).toContain(
+          '.gemini/skills — unavailable until this workspace is trusted',
+        );
+      });
+      expect(mockApplyInboxPatch).not.toHaveBeenCalled();
+
+      unmount();
+    });
+
+    it('uses canonical project-scope checks before enabling Apply', async () => {
+      mockListInboxSkills.mockResolvedValue([]);
+      mockListInboxPatches.mockResolvedValue([workspacePatch]);
+      mockIsProjectSkillPatchTarget.mockResolvedValue(true);
+
+      const config = {
+        isTrustedFolder: vi.fn().mockReturnValue(false),
+        storage: {
+          getProjectSkillsDir: vi
+            .fn()
+            .mockReturnValue('/symlinked/workspace/.gemini/skills'),
+        },
+      } as unknown as Config;
+      const { lastFrame, stdin, unmount, waitUntilReady } = await act(
+        async () =>
+          renderWithProviders(
+            <SkillInboxDialog
+              config={config}
+              onClose={vi.fn()}
+              onReloadSkills={vi.fn().mockResolvedValue(undefined)}
+            />,
+          ),
+      );
+
+      await waitFor(() => {
+        expect(lastFrame()).toContain('workspace-update');
+      });
+
+      await act(async () => {
+        stdin.write('\r');
+        await waitUntilReady();
+      });
+
+      await waitFor(() => {
+        expect(lastFrame()).toContain(
+          '.gemini/skills — unavailable until this workspace is trusted',
+        );
+      });
+      expect(mockIsProjectSkillPatchTarget).toHaveBeenCalledWith(
+        '/repo/.gemini/skills/docs-writer/SKILL.md',
+        config,
+      );
+      expect(mockApplyInboxPatch).not.toHaveBeenCalled();
+
+      unmount();
+    });
+
+    it('dismisses a patch when Dismiss is selected', async () => {
+      mockListInboxSkills.mockResolvedValue([]);
+      mockListInboxPatches.mockResolvedValue([inboxPatch]);
+
+      const config = {
+        isTrustedFolder: vi.fn().mockReturnValue(true),
+        storage: {
+          getProjectSkillsDir: vi.fn().mockReturnValue('/repo/.gemini/skills'),
+        },
+      } as unknown as Config;
+      const onReloadSkills = vi.fn().mockResolvedValue(undefined);
+      const { stdin, unmount, waitUntilReady } = await act(async () =>
+        renderWithProviders(
+          <SkillInboxDialog
+            config={config}
+            onClose={vi.fn()}
+            onReloadSkills={onReloadSkills}
+          />,
+        ),
+      );
+
+      await waitFor(() => {
+        expect(mockListInboxPatches).toHaveBeenCalled();
+      });
+
+      // Select the patch
+      await act(async () => {
+        stdin.write('\r');
+        await waitUntilReady();
+      });
+
+      // Move down to "Dismiss" and select
+      await act(async () => {
+        stdin.write('\x1b[B');
+        await waitUntilReady();
+      });
+
+      await act(async () => {
+        stdin.write('\r');
+        await waitUntilReady();
+      });
+
+      await waitFor(() => {
+        expect(mockDismissInboxPatch).toHaveBeenCalledWith(
+          config,
+          'update-docs.patch',
+        );
+      });
+      expect(onReloadSkills).not.toHaveBeenCalled();
+
+      unmount();
+    });
+
+    it('shows Windows patch entries with a basename and origin tag', async () => {
+      vi.stubEnv('USERPROFILE', 'C:\\Users\\sandy');
+      mockListInboxSkills.mockResolvedValue([]);
+      mockListInboxPatches.mockResolvedValue([windowsGlobalPatch]);
+
+      const config = {
+        isTrustedFolder: vi.fn().mockReturnValue(true),
+        storage: {
+          getProjectSkillsDir: vi
+            .fn()
+            .mockReturnValue('C:\\repo\\.gemini\\skills'),
+        },
+      } as unknown as Config;
+      const { lastFrame, unmount } = await act(async () =>
+        renderWithProviders(
+          <SkillInboxDialog
+            config={config}
+            onClose={vi.fn()}
+            onReloadSkills={vi.fn().mockResolvedValue(undefined)}
+          />,
+        ),
+      );
+
+      await waitFor(() => {
+        const frame = lastFrame();
+        expect(frame).toContain('[Global]');
+        expect(frame).toContain('SKILL.md');
+        expect(frame).not.toContain('C:\\Users\\sandy\\.gemini\\skills');
+      });
+
+      unmount();
+    });
+
+    it('renders multi-section patches without duplicate React keys', async () => {
+      mockListInboxSkills.mockResolvedValue([]);
+      mockListInboxPatches.mockResolvedValue([multiSectionPatch]);
+
+      const consoleErrorSpy = vi
+        .spyOn(console, 'error')
+        .mockImplementation(() => {});
+
+      const config = {
+        isTrustedFolder: vi.fn().mockReturnValue(true),
+        storage: {
+          getProjectSkillsDir: vi.fn().mockReturnValue('/repo/.gemini/skills'),
+        },
+      } as unknown as Config;
+      const { lastFrame, stdin, unmount, waitUntilReady } = await act(
+        async () =>
+          renderWithProviders(
+            <SkillInboxDialog
+              config={config}
+              onClose={vi.fn()}
+              onReloadSkills={vi.fn().mockResolvedValue(undefined)}
+            />,
+          ),
+      );
+
+      await waitFor(() => {
+        expect(lastFrame()).toContain('multi-section');
+      });
+
+      await act(async () => {
+        stdin.write('\r');
+        await waitUntilReady();
+      });
+
+      await waitFor(() => {
+        expect(lastFrame()).toContain('Review changes before applying');
+      });
+
+      expect(consoleErrorSpy).not.toHaveBeenCalledWith(
+        expect.stringContaining('Encountered two children with the same key'),
+      );
+
+      consoleErrorSpy.mockRestore();
+      unmount();
+    });
+  });
 });