From 296802c359f69779b83b3da9c67b4da9852d3174 Mon Sep 17 00:00:00 2001 From: "A.K.M. Adib" Date: Thu, 23 Apr 2026 09:07:30 -0400 Subject: [PATCH] fix test --- packages/cli/src/config/settingsSchema.ts | 4 ++-- scripts/tests/generate-settings-doc.test.ts | 2 ++ scripts/tests/generate-settings-schema.test.ts | 9 +++++++-- 3 files changed, 11 insertions(+), 4 deletions(-) diff --git a/packages/cli/src/config/settingsSchema.ts b/packages/cli/src/config/settingsSchema.ts index 074aad6da3..dd29a1d491 100644 --- a/packages/cli/src/config/settingsSchema.ts +++ b/packages/cli/src/config/settingsSchema.ts @@ -3344,8 +3344,8 @@ export const SETTINGS_SCHEMA_DEFINITIONS: Record< export function getSettingsSchema(): SettingsSchemaType { // Force enablePermanentToolApproval to false in Vitest to keep snapshots stable, - // unless explicitly overridden in tests. - if (process.env['VITEST']) { + // unless explicitly overridden in tests or during doc generation. + if (process.env['VITEST'] && !process.env['GENERATE_DOCS']) { // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment const schema = JSON.parse(JSON.stringify(SETTINGS_SCHEMA)); schema.security.properties.enablePermanentToolApproval.default = false; diff --git a/scripts/tests/generate-settings-doc.test.ts b/scripts/tests/generate-settings-doc.test.ts index 6e051cd15c..fcfaa296ce 100644 --- a/scripts/tests/generate-settings-doc.test.ts +++ b/scripts/tests/generate-settings-doc.test.ts @@ -17,6 +17,7 @@ vi.mock('fs', () => ({ describe('generate-settings-doc', () => { it('keeps documentation in sync in check mode', async () => { + vi.stubEnv('GENERATE_DOCS', 'true'); const previousExitCode = process.exitCode; try { process.exitCode = 0; @@ -24,6 +25,7 @@ describe('generate-settings-doc', () => { expect(process.exitCode).toBe(0); } finally { process.exitCode = previousExitCode; + vi.unstubAllEnvs(); } }); }); diff --git a/scripts/tests/generate-settings-schema.test.ts b/scripts/tests/generate-settings-schema.test.ts index a0bea9c085..98c04fd6a8 100644 --- a/scripts/tests/generate-settings-schema.test.ts +++ b/scripts/tests/generate-settings-schema.test.ts @@ -21,9 +21,14 @@ vi.mock('fs', () => ({ describe('generate-settings-schema', () => { it('keeps schema in sync in check mode', async () => { + vi.stubEnv('GENERATE_DOCS', 'true'); const previousExitCode = process.exitCode; - await expect(generateSchema(['--check'])).resolves.toBeUndefined(); - expect(process.exitCode).toBe(previousExitCode); + try { + await expect(generateSchema(['--check'])).resolves.toBeUndefined(); + expect(process.exitCode).toBe(previousExitCode); + } finally { + vi.unstubAllEnvs(); + } }); it('includes $schema property in generated schema', async () => {