MediaMetz/gemini-cli
1
0
Fork 0
mirror of https://github.com/google-gemini/gemini-cli.git synced 2026-03-10 14:10:37 -07:00
Code Issues Packages Projects Releases Wiki Activity

Use polling for extensions-reload integration test (#14391)

Browse Source
This commit is contained in:
christine betts
2025-12-02 15:35:58 -05:00
committed by GitHub
parent 752a521423
commit 2b1a791a0b
2 changed files with 68 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

56
integration-tests/extensions-reload.test.ts
View File

@@ -13,6 +13,8 @@ import { safeJsonStringify } from '@google/gemini-cli-core/src/utils/safeJsonStr
import { env } from 'node:process';
import { platform } from 'node:os';
import stripAnsi from 'strip-ansi';
const itIf = (condition: boolean) => (condition ? it : it.skip);
describe('extension reloading', () => {
@@ -76,13 +78,22 @@ describe('extension reloading', () => {
await run.expectText(
'test-extension (v0.0.1) - active (update available)',
);
// Wait a bit for the UI to settle
await new Promise((resolve) => setTimeout(resolve, 3000));
await run.sendKeys('\u0015/mcp list\r');
await run.expectText(
'test-server (from test-extension) - Ready (1 tool)',
// Wait for the UI to settle and retry the command until we see the update
await new Promise((resolve) => setTimeout(resolve, 1000));
// Poll for the updated list
await rig.pollCommand(
() => run.sendKeys('\u0015/mcp list\r'),
() => {
const output = stripAnsi(run.output);
return (
output.includes(
'test-server (from test-extension) - Ready (1 tool)',
) && output.includes('- hello')
);
},
30000, // 30s timeout
);
await run.expectText('- hello');
// Update the extension, expect the list to update, and mcp servers as well.
await run.sendKeys('\u0015/extensions update test-extension');
@@ -97,16 +108,31 @@ describe('extension reloading', () => {
await run.expectText(
'Extension "test-extension" successfully updated: 0.0.1 → 0.0.2',
);
await new Promise((resolve) => setTimeout(resolve, 3000));
await run.sendKeys('\u0015/extensions list\r');
await run.expectText('test-extension (v0.0.2) - active (updated)');
// Wait a bit for the UI to settle
await new Promise((resolve) => setTimeout(resolve, 3000));
await run.sendKeys('\u0015/mcp list\r');
await run.expectText(
'test-server (from test-extension) - Ready (1 tool)',
// Poll for the updated extension version
await rig.pollCommand(
() => run.sendKeys('\u0015/extensions list\r'),
() =>
stripAnsi(run.output).includes(
'test-extension (v0.0.2) - active (updated)',
),
30000,
);
await run.expectText('- goodbye');
// Poll for the updated mcp tool
await rig.pollCommand(
() => run.sendKeys('\u0015/mcp list\r'),
() => {
const output = stripAnsi(run.output);
return (
output.includes(
'test-server (from test-extension) - Ready (1 tool)',
) && output.includes('- goodbye')
);
},
30000,
);
await run.sendText('/quit');
await run.sendKeys('\r');

27
integration-tests/test-helper.ts
View File

@@ -159,6 +159,14 @@ interface ParsedLog {
success?: boolean;
duration_ms?: number;
request_text?: string;
hook_event_name?: string;
hook_name?: string;
hook_input?: Record<string, unknown>;
hook_output?: Record<string, unknown>;
exit_code?: number;
stdout?: string;
stderr?: string;
error?: string;
};
scopeMetrics?: {
metrics: {
@@ -1081,4 +1089,23 @@ export class TestRig {
return logs;
}
async pollCommand(
commandFn: () => Promise<void>,
predicateFn: () => boolean,
timeout: number = 30000,
interval: number = 1000,
) {
const startTime = Date.now();
while (Date.now() - startTime < timeout) {
await commandFn();
// Give it a moment to process
await new Promise((resolve) => setTimeout(resolve, 500));
if (predicateFn()) {
return;
}
await new Promise((resolve) => setTimeout(resolve, interval));
}
throw new Error(`pollCommand timed out after ${timeout}ms`);
}
}