From 2c11a9263a49a1b50e49ec8e145b370db7dfdebd Mon Sep 17 00:00:00 2001 From: Akhilesh Kumar Date: Thu, 5 Mar 2026 18:37:16 +0000 Subject: [PATCH] fix: resolve preflight test timeouts and warnings Mock shouldPromptForTerminalSetup in test environments to prevent action-required UI interruptions. Remove unnecessary dependency in useGeminiStream hook. --- packages/cli/src/test-utils/AppRig.tsx | 5 +++++ packages/cli/src/ui/AppContainer.test.tsx | 4 ++++ packages/cli/src/ui/hooks/useGeminiStream.ts | 1 - 3 files changed, 9 insertions(+), 1 deletion(-) diff --git a/packages/cli/src/test-utils/AppRig.tsx b/packages/cli/src/test-utils/AppRig.tsx index 3ff65c4067..c1b4eb53df 100644 --- a/packages/cli/src/test-utils/AppRig.tsx +++ b/packages/cli/src/test-utils/AppRig.tsx @@ -131,6 +131,11 @@ vi.mock('../ui/components/GeminiRespondingSpinner.js', async () => { }; }); +vi.mock('../ui/utils/terminalSetup.js', () => ({ + shouldPromptForTerminalSetup: vi.fn().mockResolvedValue(false), + useTerminalSetupPrompt: vi.fn(), +})); + export interface AppRigOptions { fakeResponsesPath?: string; terminalWidth?: number; diff --git a/packages/cli/src/ui/AppContainer.test.tsx b/packages/cli/src/ui/AppContainer.test.tsx index 0326aee766..827815471a 100644 --- a/packages/cli/src/ui/AppContainer.test.tsx +++ b/packages/cli/src/ui/AppContainer.test.tsx @@ -202,6 +202,10 @@ vi.mock('../utils/events.js'); vi.mock('../utils/handleAutoUpdate.js'); vi.mock('./utils/ConsolePatcher.js'); vi.mock('../utils/cleanup.js'); +vi.mock('./utils/terminalSetup.js', () => ({ + shouldPromptForTerminalSetup: vi.fn().mockResolvedValue(false), + useTerminalSetupPrompt: vi.fn(), +})); import { useHistory } from './hooks/useHistoryManager.js'; import { useThemeCommand } from './hooks/useThemeCommand.js'; diff --git a/packages/cli/src/ui/hooks/useGeminiStream.ts b/packages/cli/src/ui/hooks/useGeminiStream.ts index 3066d1c173..630566090b 100644 --- a/packages/cli/src/ui/hooks/useGeminiStream.ts +++ b/packages/cli/src/ui/hooks/useGeminiStream.ts @@ -1799,7 +1799,6 @@ export const useGeminiStream = ( addItem, registerBackgroundShell, consumeUserHint, - config, isLowErrorVerbosity, maybeAddSuppressedToolErrorNote, maybeAddLowVerbosityFailureNote,