MediaMetz/gemini-cli
1
0
Fork 0
mirror of https://github.com/google-gemini/gemini-cli.git synced 2026-03-13 23:51:16 -07:00
Code Issues Packages Projects Releases Wiki Activity

fix: prevent /copy crash on Windows by skipping /dev/tty (#15657)

Browse Source 
Co-authored-by: Jack Wotherspoon <jackwoth@google.com>
This commit is contained in:
Manoj Naik
2026-01-06 02:03:03 +05:30
committed by GitHub
parent e5d183031a
commit 2da911e4a0
2 changed files with 44 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
packages/cli/src/ui/utils/commandUtils.test.ts
View File

@@ -98,6 +98,9 @@ describe('commandUtils', () => {
beforeEach(async () => {
vi.clearAllMocks();
// Reset platform to default for test isolation
mockProcess.platform = 'darwin';
// Dynamically import and set up spawn mock
const { spawn } = await import('node:child_process');
mockSpawn = spawn as Mock;
@@ -354,6 +357,35 @@ describe('commandUtils', () => {
expect(tty.write).not.toHaveBeenCalled();
expect(tty.end).not.toHaveBeenCalled();
});
it('skips /dev/tty on Windows and uses stderr fallback for OSC-52', async () => {
mockProcess.platform = 'win32';
const stderrStream = makeWritable({ isTTY: true });
Object.defineProperty(process, 'stderr', {
value: stderrStream,
configurable: true,
});
// Set SSH environment to trigger OSC-52 path
process.env['SSH_CONNECTION'] = '1';
await copyToClipboard('windows-ssh-test');
expect(mockFs.createWriteStream).not.toHaveBeenCalled();
expect(stderrStream.write).toHaveBeenCalled();
expect(mockClipboardyWrite).not.toHaveBeenCalled();
});
it('uses clipboardy on native Windows without SSH/WSL', async () => {
mockProcess.platform = 'win32';
mockClipboardyWrite.mockResolvedValue(undefined);
await copyToClipboard('windows-native-test');
// Fallback to clipboardy and not /dev/tty
expect(mockClipboardyWrite).toHaveBeenCalledWith('windows-native-test');
expect(mockFs.createWriteStream).not.toHaveBeenCalled();
});
});
describe('getUrlOpenCommand', () => {