From 2e6c81e7ad978a7f1d914116eb6745fc2711cde9 Mon Sep 17 00:00:00 2001 From: Akhilesh Kumar Date: Wed, 11 Mar 2026 17:13:32 +0000 Subject: [PATCH] chore: address PR feedback by adding inline comments --- packages/core/src/config/config.ts | 6 +++++- packages/core/src/tools/tools.ts | 2 ++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/packages/core/src/config/config.ts b/packages/core/src/config/config.ts index 901eb269d8..e5ee70c040 100644 --- a/packages/core/src/config/config.ts +++ b/packages/core/src/config/config.ts @@ -2832,7 +2832,11 @@ export class Config implements McpContext, AgentLoopContext { } async createToolRegistry(): Promise { - const registry = new ToolRegistry(this, this.messageBus, true); + const registry = new ToolRegistry( + this, + this.messageBus, + /* isMainRegistry= */ true, + ); // helper to create & register core tools that are enabled const maybeRegister = ( diff --git a/packages/core/src/tools/tools.ts b/packages/core/src/tools/tools.ts index f00aeb2d33..5add6823b5 100644 --- a/packages/core/src/tools/tools.ts +++ b/packages/core/src/tools/tools.ts @@ -381,6 +381,8 @@ export abstract class DeclarativeTool< ) {} clone(messageBus?: MessageBus): this { + // Note: we cannot use structuredClone() here because it does not preserve + // prototype chains or handle non-serializable properties (like functions). // eslint-disable-next-line @typescript-eslint/no-unsafe-type-assertion const cloned = Object.assign( Object.create(Object.getPrototypeOf(this)),