From 3090008b1c0f60058afce5750cb01717ea3a4152 Mon Sep 17 00:00:00 2001 From: "N. Taylor Mullen" Date: Sat, 10 Jan 2026 03:59:38 -0800 Subject: [PATCH] fix(skills): remove "Restart required" message from non-interactive commands (#16307) --- packages/cli/src/commands/skills/disable.test.ts | 2 +- packages/cli/src/commands/skills/disable.ts | 5 +---- packages/cli/src/commands/skills/enable.test.ts | 4 ++-- packages/cli/src/commands/skills/enable.ts | 5 +---- 4 files changed, 5 insertions(+), 11 deletions(-) diff --git a/packages/cli/src/commands/skills/disable.test.ts b/packages/cli/src/commands/skills/disable.test.ts index 4fa8403702..b7bc8805c8 100644 --- a/packages/cli/src/commands/skills/disable.test.ts +++ b/packages/cli/src/commands/skills/disable.test.ts @@ -80,7 +80,7 @@ describe('skills disable command', () => { ); expect(emitConsoleLog).toHaveBeenCalledWith( 'log', - 'Skill "skill1" disabled by adding it to the disabled list in user (/user/settings.json) settings. Restart required to take effect.', + 'Skill "skill1" disabled by adding it to the disabled list in user (/user/settings.json) settings.', ); }); diff --git a/packages/cli/src/commands/skills/disable.ts b/packages/cli/src/commands/skills/disable.ts index f1831654f5..e0b657afbc 100644 --- a/packages/cli/src/commands/skills/disable.ts +++ b/packages/cli/src/commands/skills/disable.ts @@ -23,13 +23,10 @@ export async function handleDisable(args: DisableArgs) { const settings = loadSettings(workspaceDir); const result = disableSkill(settings, name, scope); - let feedback = renderSkillActionFeedback( + const feedback = renderSkillActionFeedback( result, (label, path) => `${chalk.bold(label)} (${chalk.dim(path)})`, ); - if (result.status === 'success') { - feedback += ' Restart required to take effect.'; - } debugLogger.log(feedback); } diff --git a/packages/cli/src/commands/skills/enable.test.ts b/packages/cli/src/commands/skills/enable.test.ts index b3a96d5967..5874072130 100644 --- a/packages/cli/src/commands/skills/enable.test.ts +++ b/packages/cli/src/commands/skills/enable.test.ts @@ -81,7 +81,7 @@ describe('skills enable command', () => { ); expect(emitConsoleLog).toHaveBeenCalledWith( 'log', - 'Skill "skill1" enabled by removing it from the disabled list in user (/user/settings.json) and project (/project/settings.json) settings. Restart required to take effect.', + 'Skill "skill1" enabled by removing it from the disabled list in user (/user/settings.json) and project (/project/settings.json) settings.', ); }); @@ -122,7 +122,7 @@ describe('skills enable command', () => { ); expect(emitConsoleLog).toHaveBeenCalledWith( 'log', - 'Skill "skill1" enabled by removing it from the disabled list in project (/workspace/settings.json) and user (/user/settings.json) settings. Restart required to take effect.', + 'Skill "skill1" enabled by removing it from the disabled list in project (/workspace/settings.json) and user (/user/settings.json) settings.', ); }); diff --git a/packages/cli/src/commands/skills/enable.ts b/packages/cli/src/commands/skills/enable.ts index 1e1cc12e49..bc9d0066b1 100644 --- a/packages/cli/src/commands/skills/enable.ts +++ b/packages/cli/src/commands/skills/enable.ts @@ -22,13 +22,10 @@ export async function handleEnable(args: EnableArgs) { const settings = loadSettings(workspaceDir); const result = enableSkill(settings, name); - let feedback = renderSkillActionFeedback( + const feedback = renderSkillActionFeedback( result, (label, path) => `${chalk.bold(label)} (${chalk.dim(path)})`, ); - if (result.status === 'success') { - feedback += ' Restart required to take effect.'; - } debugLogger.log(feedback); }