feat: Map tool kinds to explicit ACP.ToolKind values and update test … (#19547)

This commit is contained in:
Sri Pasumarthi
2026-02-23 10:22:05 -08:00
committed by GitHub
parent 2e3cbd6363
commit 3966f3c053
4 changed files with 149 additions and 4 deletions
@@ -682,6 +682,13 @@ export class Session {
path: confirmationDetails.fileName,
oldText: confirmationDetails.originalContent,
newText: confirmationDetails.newContent,
_meta: {
kind: !confirmationDetails.originalContent
? 'add'
: confirmationDetails.newContent === ''
? 'delete'
: 'modify',
},
});
}
@@ -1203,6 +1210,13 @@ function toToolCallContent(toolResult: ToolResult): acp.ToolCallContent | null {
path: toolResult.returnDisplay.fileName,
oldText: toolResult.returnDisplay.originalContent,
newText: toolResult.returnDisplay.newContent,
_meta: {
kind: !toolResult.returnDisplay.originalContent
? 'add'
: toolResult.returnDisplay.newContent === ''
? 'delete'
: 'modify',
},
};
}
return null;
@@ -1291,14 +1305,16 @@ function toAcpToolKind(kind: Kind): acp.ToolKind {
switch (kind) {
case Kind.Read:
case Kind.Edit:
case Kind.Execute:
case Kind.Search:
case Kind.Delete:
case Kind.Move:
case Kind.Search:
case Kind.Execute:
case Kind.Think:
case Kind.Fetch:
case Kind.SwitchMode:
case Kind.Other:
return kind as acp.ToolKind;
case Kind.Plan:
case Kind.Communicate:
default:
return 'other';