MediaMetz/gemini-cli
1
0
Fork 0
mirror of https://github.com/google-gemini/gemini-cli.git synced 2026-04-11 05:41:08 -07:00
Code Issues Packages Projects Releases Wiki Activity

fix(browser): reset action counter for each agent session and let it ignore internal actions (#24228)

Browse Source
This commit is contained in:
cynthialong0-0
2026-03-31 08:23:19 -07:00
committed by GitHub
parent e293424bb4
commit 3982a252bb
6 changed files with 51 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
packages/core/src/agents/browser/browserManager.ts
View File

@@ -215,26 +215,30 @@ export class BrowserManager {
* @param toolName The name of the tool to call
* @param args Arguments to pass to the tool
* @param signal Optional AbortSignal to cancel the call
* @param isInternal Determine if the tool is for internal execution
* @returns The result from the MCP server
*/
async callTool(
toolName: string,
args: Record<string, unknown>,
signal?: AbortSignal,
isInternal: boolean = false,
): Promise<McpToolCallResult> {
if (signal?.aborted) {
throw signal.reason ?? new Error('Operation cancelled');
}
// Hard enforcement of per-action rate limit
if (this.actionCounter > this.maxActionsPerTask) {
const error = new Error(
`Browser agent reached maximum action limit (${this.maxActionsPerTask}). ` +
`Task terminated to prevent runaway execution. To config the limit, use maxActionsPerTask in the settings.`,
);
throw error;
if (!isInternal) {
if (this.actionCounter >= this.maxActionsPerTask) {
const error = new Error(
`Browser agent reached maximum action limit (${this.maxActionsPerTask}). ` +
`Task terminated to prevent runaway execution. To config the limit, use maxActionsPerTask in the settings.`,
);
throw error;
}
this.actionCounter++;
}
this.actionCounter++;
const errorMessage = this.checkNavigationRestrictions(toolName, args);
if (errorMessage) {
@@ -588,6 +592,8 @@ export class BrowserManager {
debugLogger.log('MCP client connected to chrome-devtools-mcp');
await this.discoverTools();
this.registerInputBlockerHandler();
// clear the action counter for each connection
this.actionCounter = 0;
})(),
new Promise<never>((_, reject) => {
timeoutId = setTimeout(