MediaMetz/gemini-cli
1
0
Fork 0
mirror of https://github.com/google-gemini/gemini-cli.git synced 2026-05-12 21:03:05 -07:00
Code Issues Packages Projects Releases Wiki Activity

fix(core): avoid 'activate_skill' re-registration warning (#16398)

Browse Source
This commit is contained in:
N. Taylor Mullen
2026-01-12 11:31:34 -08:00
committed by GitHub
parent 64cde8d439
commit 3b678a4da0
2 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/core/src/config/config.test.ts
+1 -1
View File
@@ -2029,7 +2029,7 @@ describe('Config JIT Initialization', () => {
expect(mockOnReload).toHaveBeenCalled(); expect(mockOnReload).toHaveBeenCalled();
expect(skillManager.setDisabledSkills).toHaveBeenCalledWith(['skill2']); expect(skillManager.setDisabledSkills).toHaveBeenCalledWith(['skill2']);
expect(toolRegistry.registerTool).toHaveBeenCalled(); expect(toolRegistry.registerTool).toHaveBeenCalled();
expect(toolRegistry.unregisterTool).not.toHaveBeenCalledWith( expect(toolRegistry.unregisterTool).toHaveBeenCalledWith(
ACTIVATE_SKILL_TOOL_NAME, ACTIVATE_SKILL_TOOL_NAME,
); );
}); });
packages/core/src/config/config.ts
+2
View File
@@ -761,6 +761,7 @@ export class Config {
// Re-register ActivateSkillTool to update its schema with the discovered enabled skill enums // Re-register ActivateSkillTool to update its schema with the discovered enabled skill enums
if (this.getSkillManager().getSkills().length > 0) { if (this.getSkillManager().getSkills().length > 0) {
this.getToolRegistry().unregisterTool(ActivateSkillTool.Name);
this.getToolRegistry().registerTool( this.getToolRegistry().registerTool(
new ActivateSkillTool(this, this.messageBus), new ActivateSkillTool(this, this.messageBus),
); );
@@ -1568,6 +1569,7 @@ export class Config {
// Re-register ActivateSkillTool to update its schema with the newly discovered skills // Re-register ActivateSkillTool to update its schema with the newly discovered skills
if (this.getSkillManager().getSkills().length > 0) { if (this.getSkillManager().getSkills().length > 0) {
this.getToolRegistry().unregisterTool(ActivateSkillTool.Name);
this.getToolRegistry().registerTool( this.getToolRegistry().registerTool(
new ActivateSkillTool(this, this.messageBus), new ActivateSkillTool(this, this.messageBus),
); );