refactor(core): consolidate execute() arguments into ExecuteOptions (#25101)

This commit is contained in:
Michael Bleigh
2026-04-10 10:11:17 -07:00
committed by GitHub
parent 1d36309f5f
commit 3b7c17a22c
69 changed files with 849 additions and 527 deletions

View File

@@ -14,7 +14,6 @@ import {
Kind,
type ToolCallConfirmationDetails,
type ToolInvocation,
type ToolLiveOutput,
type ToolResult,
type ExecuteOptions,
} from '../tools/tools.js';
@@ -54,11 +53,8 @@ class MockToolInvocation extends BaseToolInvocation<
super(params, messageBus, tool.name, tool.displayName);
}
execute(
signal: AbortSignal,
updateOutput?: (output: ToolLiveOutput) => void,
options?: ExecuteOptions,
): Promise<ToolResult> {
execute(options: ExecuteOptions): Promise<ToolResult> {
const { abortSignal: signal, updateOutput } = options;
return this.tool.execute(
this.params,
signal,
@@ -158,11 +154,10 @@ export class MockModifiableToolInvocation extends BaseToolInvocation<
super(params, messageBus, tool.name, tool.displayName);
}
async execute(
_signal: AbortSignal,
_updateOutput?: (output: ToolLiveOutput) => void,
_options?: ExecuteOptions,
): Promise<ToolResult> {
async execute({
abortSignal: _signal,
updateOutput: _updateOutput,
}: ExecuteOptions): Promise<ToolResult> {
const result = this.tool.executeFn(this.params);
return (
result ?? {