MediaMetz/gemini-cli
1
0
Fork 0
mirror of https://github.com/google-gemini/gemini-cli.git synced 2026-05-12 12:54:07 -07:00
Code Issues Packages Projects Releases Wiki Activity

fix(core): allow /memory add to work in plan mode (#20353)

Browse Source
This commit is contained in:
Jeffrey Ying
2026-02-26 08:59:44 -05:00
committed by GitHub
parent 8380f0a3b1
commit 3db35812b7
3 changed files with 11 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/core/src/policy/policies/plan.toml
+1 -1
View File
@@ -50,7 +50,7 @@ priority = 70
modes = ["plan"]
[[rule]]
toolName = ["ask_user", "exit_plan_mode"]
toolName = ["ask_user", "exit_plan_mode", "save_memory"]
decision = "ask_user"
priority = 70
modes = ["plan"]
packages/core/src/policy/policy-engine.test.ts
+8
View File
@@ -2601,6 +2601,12 @@ describe('PolicyEngine', () => {
priority: 70,
modes: [ApprovalMode.PLAN],
},
{
toolName: 'save_memory',
decision: PolicyDecision.ASK_USER,
priority: 70,
modes: [ApprovalMode.PLAN],
},
{
toolName: 'exit_plan_mode',
decision: PolicyDecision.ASK_USER,
@@ -2638,6 +2644,7 @@ describe('PolicyEngine', () => {
'web_fetch',
'write_todos',
'memory',
'save_memory',
'read_tool',
'write_tool',
]);
@@ -2667,6 +2674,7 @@ describe('PolicyEngine', () => {
expect(excluded.has('activate_skill')).toBe(false);
expect(excluded.has('ask_user')).toBe(false);
expect(excluded.has('exit_plan_mode')).toBe(false);
expect(excluded.has('save_memory')).toBe(false);
// Read-only MCP tool allowed by annotation rule (matched via _serverName)
expect(excluded.has('read_tool')).toBe(false);
});