feat(cli): add experiment gate for event-driven scheduler (#17055)

This commit is contained in:
Abhi
2026-01-19 22:59:30 -05:00
committed by GitHub
parent 155d9aafe2
commit 451e0b49cb
7 changed files with 61 additions and 0 deletions
+2
View File
@@ -721,6 +721,8 @@ export async function loadCliConfig(
enableExtensionReloading: settings.experimental?.extensionReloading,
enableAgents: settings.experimental?.enableAgents,
plan: settings.experimental?.plan,
enableEventDrivenScheduler:
settings.experimental?.enableEventDrivenScheduler,
skillsSupport:
settings.experimental?.skills || (settings.skills?.enabled ?? true),
disabledSkills: settings.skills?.disabled,
@@ -381,6 +381,20 @@ describe('SettingsSchema', () => {
);
});
it('should have enableEventDrivenScheduler setting in schema', () => {
const setting =
getSettingsSchema().experimental.properties.enableEventDrivenScheduler;
expect(setting).toBeDefined();
expect(setting.type).toBe('boolean');
expect(setting.category).toBe('Experimental');
expect(setting.default).toBe(false);
expect(setting.requiresRestart).toBe(true);
expect(setting.showInDialog).toBe(false);
expect(setting.description).toBe(
'Enables event-driven scheduler within the CLI session.',
);
});
it('should have hooks.notifications setting in schema', () => {
const setting = getSettingsSchema().hooks.properties.notifications;
expect(setting).toBeDefined();
@@ -1424,6 +1424,15 @@ const SETTINGS_SCHEMA = {
description: 'Enable requesting and fetching of extension settings.',
showInDialog: false,
},
enableEventDrivenScheduler: {
type: 'boolean',
label: 'Event Driven Scheduler',
category: 'Experimental',
requiresRestart: true,
default: false,
description: 'Enables event-driven scheduler within the CLI session.',
showInDialog: false,
},
extensionReloading: {
type: 'boolean',
label: 'Extension Reloading',
+16
View File
@@ -855,6 +855,22 @@ describe('Server Config (config.ts)', () => {
});
});
describe('Event Driven Scheduler Configuration', () => {
it('should default enableEventDrivenScheduler to false when not provided', () => {
const config = new Config(baseParams);
expect(config.isEventDrivenSchedulerEnabled()).toBe(false);
});
it('should set enableEventDrivenScheduler to false when provided as false', () => {
const params: ConfigParameters = {
...baseParams,
enableEventDrivenScheduler: false,
};
const config = new Config(params);
expect(config.isEventDrivenSchedulerEnabled()).toBe(false);
});
});
describe('Shell Tool Inactivity Timeout', () => {
it('should default to 300000ms (300 seconds) when not provided', () => {
const config = new Config(baseParams);
+8
View File
@@ -379,6 +379,7 @@ export interface ConfigParameters {
};
previewFeatures?: boolean;
enableAgents?: boolean;
enableEventDrivenScheduler?: boolean;
skillsSupport?: boolean;
disabledSkills?: string[];
adminSkillsEnabled?: boolean;
@@ -531,6 +532,7 @@ export class Config {
private readonly enableAgents: boolean;
private agents: AgentSettings;
private readonly enableEventDrivenScheduler: boolean;
private readonly skillsSupport: boolean;
private disabledSkills: string[];
private readonly adminSkillsEnabled: boolean;
@@ -618,6 +620,8 @@ export class Config {
this.agents = params.agents ?? {};
this.disableLLMCorrection = params.disableLLMCorrection ?? false;
this.planEnabled = params.plan ?? false;
this.enableEventDrivenScheduler =
params.enableEventDrivenScheduler ?? false;
this.skillsSupport = params.skillsSupport ?? false;
this.disabledSkills = params.disabledSkills ?? [];
this.adminSkillsEnabled = params.adminSkillsEnabled ?? true;
@@ -1520,6 +1524,10 @@ export class Config {
return this.enableAgents;
}
isEventDrivenSchedulerEnabled(): boolean {
return this.enableEventDrivenScheduler;
}
getNoBrowser(): boolean {
return this.noBrowser;
}