chore(automation): ensure status/need-triage is applied and never cleared automatically (#16657)

.github/scripts/pr-triage.sh

@@ -1,4 +1,8 @@
 #!/usr/bin/env bash
+# @license
+# Copyright 2026 Google LLC
+# SPDX-License-Identifier: Apache-2.0
+
 set -euo pipefail
 
 # Initialize a comma-separated string to hold PR numbers that need a comment
@@ -10,7 +14,7 @@ ISSUE_LABELS_CACHE_FLAT=""
 
 # Function to get area and priority labels from an issue (with caching)
 get_issue_labels() {
-    local ISSUE_NUM=$1
+    local ISSUE_NUM="${1}"
     if [[ -z "${ISSUE_NUM}" || "${ISSUE_NUM}" == "null" || "${ISSUE_NUM}" == "" ]]; then
         return
     fi
@@ -18,10 +22,13 @@ get_issue_labels() {
     # Check cache
     case " ${ISSUE_LABELS_CACHE_FLAT} " in
         *" ${ISSUE_NUM}:"*) 
-            local suffix="${ISSUE_LABELS_CACHE_FLAT#* ${ISSUE_NUM}:}"
+            local suffix="${ISSUE_LABELS_CACHE_FLAT#* " ${ISSUE_NUM}:"}"
             echo "${suffix%% *}"
             return
             ;; 
+        *)
+            # Cache miss, proceed to fetch
+            ;;
     esac
 
     echo "   📥 Fetching area and priority labels from issue #${ISSUE_NUM}" >&2
@@ -33,19 +40,19 @@ get_issue_labels() {
     fi
 
     local labels
-    labels=$(echo "${gh_output}" | grep -E "^(area|priority)/" | tr '\n' ',' | sed 's/,$//' || echo "")
+    labels=$(echo "${gh_output}" | grep -E '^(area|priority)/' | tr '\n' ',' | sed 's/,$//' || echo "")
     
     # Save to flat cache
     ISSUE_LABELS_CACHE_FLAT="${ISSUE_LABELS_CACHE_FLAT} ${ISSUE_NUM}:${labels}"
-    echo "$labels"
+    echo "${labels}"
 }
 
 # Function to process a single PR with pre-fetched data
 process_pr_optimized() {
-    local PR_NUMBER=$1
-    local IS_DRAFT=$2
-    local ISSUE_NUMBER=$3
-    local CURRENT_LABELS=$4 # Comma-separated labels
+    local PR_NUMBER="${1}"
+    local IS_DRAFT="${2}"
+    local ISSUE_NUMBER="${3}"
+    local CURRENT_LABELS="${4}" # Comma-separated labels
 
     echo "🔄 Processing PR #${PR_NUMBER}"
 
@@ -84,7 +91,7 @@ process_pr_optimized() {
         ISSUE_LABELS=$(get_issue_labels "${ISSUE_NUMBER}")
 
         if [[ -n "${ISSUE_LABELS}" ]]; then
-            local IFS_OLD=$IFS
+            local IFS_OLD="${IFS}"
             IFS=','
             for label in ${ISSUE_LABELS}; do
                 if [[ -n "${label}" ]] && [[ ",${CURRENT_LABELS}," != *",${label},"* ]]; then
@@ -94,8 +101,8 @@ process_pr_optimized() {
                         LABELS_TO_ADD="${LABELS_TO_ADD},${label}"
                     fi
                 fi
-            done
-            IFS=$IFS_OLD
+done
+            IFS="${IFS_OLD}"
         fi
 
         if [[ -z "${LABELS_TO_ADD}" && -z "${LABELS_TO_REMOVE}" ]]; then
@@ -135,7 +142,7 @@ JQ_EXTRACT_FIELDS='{
     labels: [.labels[].name] | join(",")
 }'
 
-JQ_TSV_FORMAT='"\((.number | tostring))\t\(.isDraft)\t\((.issue // "null") | tostring)\t\(.labels)"'
+JQ_TSV_FORMAT='"\((.number | tostring))\t\(.isDraft)\t\((.issue // \"null\") | tostring)\t\(.labels)"' # Corrected escaping for quotes within the string literal
 
 if [[ -n "${PR_NUMBER:-}" ]]; then
     echo "🔄 Processing single PR #${PR_NUMBER}"
@@ -144,9 +151,9 @@ if [[ -n "${PR_NUMBER:-}" ]]; then
         exit 1
     }
     
-    line=$(echo "$PR_DATA" | jq -r "$JQ_EXTRACT_FIELDS | $JQ_TSV_FORMAT")
-    IFS=$'\t' read -r pr_num is_draft issue_num current_labels <<< "$line"
-    process_pr_optimized "$pr_num" "$is_draft" "$issue_num" "$current_labels"
+    line=$(echo "${PR_DATA}" | jq -r "${JQ_EXTRACT_FIELDS} | ${JQ_TSV_FORMAT}")
+    IFS=$'\t' read -r pr_num is_draft issue_num current_labels <<< "${line}"
+    process_pr_optimized "${pr_num}" "${is_draft}" "${issue_num}" "${current_labels}"
 else
     echo "📥 Getting all open pull requests..."
     PR_DATA_ALL=$(gh pr list --repo "${GITHUB_REPOSITORY}" --state open --limit 1000 --json number,closingIssuesReferences,isDraft,body,labels 2>/dev/null) || {
@@ -157,11 +164,15 @@ else
     PR_COUNT=$(echo "${PR_DATA_ALL}" | jq '. | length')
     echo "📊 Found ${PR_COUNT} open PRs to process"
 
+    # Use a temporary file to avoid masking exit codes in process substitution
+    tmp_file=$(mktemp)
+    echo "${PR_DATA_ALL}" | jq -r ".[] | ${JQ_EXTRACT_FIELDS} | ${JQ_TSV_FORMAT}" > "${tmp_file}"
     while read -r line; do
-        [[ -z "$line" ]] && continue
-        IFS=$'\t' read -r pr_num is_draft issue_num current_labels <<< "$line"
-        process_pr_optimized "$pr_num" "$is_draft" "$issue_num" "$current_labels"
-    done < <(echo "${PR_DATA_ALL}" | jq -r ".[] | $JQ_EXTRACT_FIELDS | $JQ_TSV_FORMAT")
+        [[ -z "${line}" ]] && continue
+        IFS=$'\t' read -r pr_num is_draft issue_num current_labels <<< "${line}"
+        process_pr_optimized "${pr_num}" "${is_draft}" "${issue_num}" "${current_labels}"
+    done < "${tmp_file}"
+    rm -f "${tmp_file}"
 fi
 
 if [[ -z "${PRS_NEEDING_COMMENT}" ]]; then
@@ -170,4 +181,4 @@ else
     echo "prs_needing_comment=[${PRS_NEEDING_COMMENT}]" >> "${GITHUB_OUTPUT}"
 fi
 
-echo "✅ PR triage completed"
+echo "✅ PR triage completed"