MediaMetz/gemini-cli
1
0
Fork 0
mirror of https://github.com/google-gemini/gemini-cli.git synced 2026-04-08 20:30:53 -07:00
Code Issues Packages Projects Releases Wiki Activity

Refactor: Migrate CLI appEvents to Core coreEvents (#15737)

Browse Source
This commit is contained in:
Adib234
2026-01-23 11:45:46 -05:00
committed by GitHub
parent 0b7d26c9e3
commit 488d5fc439
13 changed files with 90 additions and 93 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
packages/cli/src/ui/hooks/slashCommandProcessor.test.tsx
View File

@@ -20,8 +20,8 @@ import {
type GeminiClient,
SlashCommandStatus,
makeFakeConfig,
coreEvents,
} from '@google/gemini-cli-core';
import { appEvents } from '../../utils/events.js';
const {
logSlashCommand,
@@ -1044,7 +1044,7 @@ describe('useSlashCommandProcessor', () => {
// We should not see a change until we fire an event.
await waitFor(() => expect(result.current.slashCommands).toEqual([]));
act(() => {
appEvents.emit('extensionsStarting');
coreEvents.emit('extensionsStarting');
});
await waitFor(() =>
expect(result.current.slashCommands).toEqual([newCommand]),

10
packages/cli/src/ui/hooks/slashCommandProcessor.ts
View File

@@ -30,6 +30,7 @@ import {
ToolConfirmationOutcome,
Storage,
IdeClient,
coreEvents,
addMCPStatusChangeListener,
removeMCPStatusChangeListener,
MCPDiscoveryState,
@@ -55,7 +56,6 @@ import {
type ExtensionUpdateAction,
type ExtensionUpdateStatus,
} from '../state/extensions.js';
import { appEvents } from '../../utils/events.js';
import {
LogoutConfirmationDialog,
LogoutChoice,
@@ -295,8 +295,8 @@ export const useSlashCommandProcessor = (
// starting/stopping
reloadCommands();
};
appEvents.on('extensionsStarting', extensionEventListener);
appEvents.on('extensionsStopping', extensionEventListener);
coreEvents.on('extensionsStarting', extensionEventListener);
coreEvents.on('extensionsStopping', extensionEventListener);
return () => {
// eslint-disable-next-line @typescript-eslint/no-floating-promises
@@ -305,8 +305,8 @@ export const useSlashCommandProcessor = (
ideClient.removeStatusChangeListener(listener);
})();
removeMCPStatusChangeListener(listener);
appEvents.off('extensionsStarting', extensionEventListener);
appEvents.off('extensionsStopping', extensionEventListener);
coreEvents.off('extensionsStarting', extensionEventListener);
coreEvents.off('extensionsStopping', extensionEventListener);
};
}, [config, reloadCommands]);