From 48e8c12476b6fd8e2e3d5ca77269d86618c717a8 Mon Sep 17 00:00:00 2001
From: Sehoon Shon <sshon@google.com>
Date: Thu, 4 Dec 2025 10:44:21 -0500
Subject: [PATCH] remove unused isSearching field (#14509)

---
 .../cli/src/ui/components/SettingsDialog.tsx  | 33 ++-----------------
 1 file changed, 2 insertions(+), 31 deletions(-)

diff --git a/packages/cli/src/ui/components/SettingsDialog.tsx b/packages/cli/src/ui/components/SettingsDialog.tsx
index f8b165c1c7..8ab94bc57e 100644
--- a/packages/cli/src/ui/components/SettingsDialog.tsx
+++ b/packages/cli/src/ui/components/SettingsDialog.tsx
@@ -92,7 +92,6 @@ export function SettingsDialog({
   const [showRestartPrompt, setShowRestartPrompt] = useState(false);
 
   // Search state
-  const [isSearching, setIsSearching] = useState(false);
   const [searchQuery, setSearchQuery] = useState('');
   const [filteredKeys, setFilteredKeys] = useState<string[]>(() =>
     getDialogSettingKeys(),
@@ -195,8 +194,7 @@ export function SettingsDialog({
   }, [selectedScope, settings, globalPendingChanges]);
 
   const generateSettingsItems = () => {
-    const settingKeys =
-      isSearching || searchQuery ? filteredKeys : getDialogSettingKeys();
+    const settingKeys = searchQuery ? filteredKeys : getDialogSettingKeys();
 
     return settingKeys.map((key: string) => {
       const definition = getSettingDefinition(key);
@@ -563,33 +561,6 @@ export function SettingsDialog({
     (key) => {
       const { name } = key;
 
-      if (isSearching) {
-        if (keyMatchers[Command.ESCAPE](key)) {
-          setIsSearching(false);
-          setSearchQuery('');
-          return;
-        }
-        if (keyMatchers[Command.RETURN](key)) {
-          setIsSearching(false);
-          return;
-        }
-        if (name === 'backspace') {
-          setSearchQuery((prev) => prev.slice(0, -1));
-          return;
-        }
-        if (
-          key.sequence &&
-          key.sequence.length === 1 &&
-          !key.ctrl &&
-          !key.meta &&
-          !keyMatchers[Command.DIALOG_NAVIGATION_UP](key) &&
-          !keyMatchers[Command.DIALOG_NAVIGATION_DOWN](key)
-        ) {
-          setSearchQuery((prev) => prev + key.sequence);
-          return;
-        }
-      }
-
       if (name === 'tab' && showScopeSelection) {
         setFocusSection((prev) => (prev === 'settings' ? 'scope' : 'settings'));
       }
@@ -908,7 +879,7 @@ export function SettingsDialog({
           />
         </Box>
         <Box height={1} />
-        {isSearching && visibleItems.length === 0 ? (
+        {visibleItems.length === 0 ? (
           <Box marginX={1} height={1} flexDirection="column">
             <Text color={theme.text.secondary}>No matches found.</Text>
           </Box>