From 4ee082011738ecdfcc50da30185d08c3920ea5d6 Mon Sep 17 00:00:00 2001 From: mkorwel Date: Thu, 23 Oct 2025 15:20:36 -0700 Subject: [PATCH] fix(ci): expand get-vars job and update dependencies in orchestrator Expanded the `get-vars` job in `orchestrator.yml` to output `npm-registry-scope` and `npm-registry-url` in addition to `cli-package-name`. The `build-and-publish` and `e2e` jobs now correctly depend on `get-vars` and consume all three outputs, ensuring proper plumbing of environment variables for the Docker build. --- .github/workflows/orchestrator.yml | 25 +++++++++++++++---------- 1 file changed, 15 insertions(+), 10 deletions(-) diff --git a/.github/workflows/orchestrator.yml b/.github/workflows/orchestrator.yml index 07f47ed383..fc7c26e1f6 100644 --- a/.github/workflows/orchestrator.yml +++ b/.github/workflows/orchestrator.yml @@ -36,24 +36,29 @@ jobs: name: 'Lint' uses: './.github/workflows/lint.yml' - build-and-publish: - name: 'Build and Publish CI Bundle' - needs: 'lint' - uses: './.github/workflows/build-and-publish.yml' - with: - cli-package-name: '${{ vars.CLI_PACKAGE_NAME }}' - npm-registry-scope: '${{ vars.NPM_REGISTRY_SCOPE }}' - npm-registry-url: '${{ vars.NPM_REGISTRY_URL }}' - get-vars: name: 'Get Environment Variables' runs-on: 'ubuntu-latest' environment: 'dev' outputs: cli-package-name: '${{ steps.get-vars.outputs.cli-package-name }}' + npm-registry-scope: '${{ steps.get-vars.outputs.npm-registry-scope }}' + npm-registry-url: '${{ steps.get-vars.outputs.npm-registry-url }}' steps: - id: 'get-vars' - run: 'echo ''cli-package-name=''''${{ vars.CLI_PACKAGE_NAME }}'''''' >> "$GITHUB_OUTPUT"' + run: | + echo 'cli-package-name=${{ vars.CLI_PACKAGE_NAME }}' >> "$GITHUB_OUTPUT" + echo 'npm-registry-scope=${{ vars.NPM_REGISTRY_SCOPE }}' >> "$GITHUB_OUTPUT" + echo 'npm-registry-url=${{ vars.NPM_REGISTRY_URL }}' >> "$GITHUB_OUTPUT" + + build-and-publish: + name: 'Build and Publish CI Bundle' + needs: ['lint', 'get-vars'] + uses: './.github/workflows/build-and-publish.yml' + with: + cli-package-name: '${{ needs.get-vars.outputs.cli-package-name }}' + npm-registry-scope: '${{ needs.get-vars.outputs.npm-registry-scope }}' + npm-registry-url: '${{ needs.get-vars.outputs.npm-registry-url }}' ci: name: 'CI Checks'