MediaMetz/gemini-cli
1
0
Fork 0
mirror of https://github.com/google-gemini/gemini-cli.git synced 2026-04-10 21:30:40 -07:00
Code Issues Packages Projects Releases Wiki Activity

fix(core): update loop detection LLM schema fields (#12091)

Browse Source
This commit is contained in:
Sandy Tao
2025-10-27 12:16:25 -07:00
committed by GitHub
parent 29efebe38f
commit 4ef3c09332
2 changed files with 29 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
packages/core/src/services/loopDetectionService.test.ts
View File

@@ -671,7 +671,7 @@ describe('LoopDetectionService LLM Checks', () => {
it('should trigger LLM check on the 30th turn', async () => {
mockBaseLlmClient.generateJson = vi
.fn()
.mockResolvedValue({ confidence: 0.1 });
.mockResolvedValue({ unproductive_state_confidence: 0.1 });
await advanceTurns(30);
expect(mockBaseLlmClient.generateJson).toHaveBeenCalledTimes(1);
expect(mockBaseLlmClient.generateJson).toHaveBeenCalledWith(
@@ -687,9 +687,10 @@ describe('LoopDetectionService LLM Checks', () => {
it('should detect a cognitive loop when confidence is high', async () => {
// First check at turn 30
mockBaseLlmClient.generateJson = vi
.fn()
.mockResolvedValue({ confidence: 0.85, reasoning: 'Repetitive actions' });
mockBaseLlmClient.generateJson = vi.fn().mockResolvedValue({
unproductive_state_confidence: 0.85,
unproductive_state_analysis: 'Repetitive actions',
});
await advanceTurns(30);
expect(mockBaseLlmClient.generateJson).toHaveBeenCalledTimes(1);
@@ -697,9 +698,10 @@ describe('LoopDetectionService LLM Checks', () => {
// The interval will be: 5 + (15 - 5) * (1 - 0.85) = 5 + 10 * 0.15 = 6.5 -> rounded to 7
await advanceTurns(6); // advance to turn 36
mockBaseLlmClient.generateJson = vi
.fn()
.mockResolvedValue({ confidence: 0.95, reasoning: 'Repetitive actions' });
mockBaseLlmClient.generateJson = vi.fn().mockResolvedValue({
unproductive_state_confidence: 0.95,
unproductive_state_analysis: 'Repetitive actions',
});
const finalResult = await service.turnStarted(abortController.signal); // This is turn 37
expect(finalResult).toBe(true);
@@ -713,9 +715,10 @@ describe('LoopDetectionService LLM Checks', () => {
});
it('should not detect a loop when confidence is low', async () => {
mockBaseLlmClient.generateJson = vi
.fn()
.mockResolvedValue({ confidence: 0.5, reasoning: 'Looks okay' });
mockBaseLlmClient.generateJson = vi.fn().mockResolvedValue({
unproductive_state_confidence: 0.5,
unproductive_state_analysis: 'Looks okay',
});
await advanceTurns(30);
const result = await service.turnStarted(abortController.signal);
expect(result).toBe(false);
@@ -726,7 +729,7 @@ describe('LoopDetectionService LLM Checks', () => {
// Confidence is 0.0, so interval should be MAX_LLM_CHECK_INTERVAL (15)
mockBaseLlmClient.generateJson = vi
.fn()
.mockResolvedValue({ confidence: 0.0 });
.mockResolvedValue({ unproductive_state_confidence: 0.0 });
await advanceTurns(30); // First check at turn 30
expect(mockBaseLlmClient.generateJson).toHaveBeenCalledTimes(1);
@@ -771,7 +774,7 @@ describe('LoopDetectionService LLM Checks', () => {
mockBaseLlmClient.generateJson = vi
.fn()
.mockResolvedValue({ confidence: 0.1 });
.mockResolvedValue({ unproductive_state_confidence: 0.1 });
await advanceTurns(30);