From 533a3fb312ad4ac5cb99d0c303812cbd6aafa2f4 Mon Sep 17 00:00:00 2001 From: Allen Hutchison Date: Tue, 2 Dec 2025 16:05:54 -0800 Subject: [PATCH] feat: enable message bus integration by default (#14329) --- docs/get-started/configuration.md | 2 +- packages/cli/src/config/config.test.ts | 8 ++++++++ packages/cli/src/config/config.ts | 2 +- packages/cli/src/config/settingsSchema.ts | 2 +- schemas/settings.schema.json | 4 ++-- 5 files changed, 13 insertions(+), 5 deletions(-) diff --git a/docs/get-started/configuration.md b/docs/get-started/configuration.md index 255e828571..948b1be04f 100644 --- a/docs/get-started/configuration.md +++ b/docs/get-started/configuration.md @@ -668,7 +668,7 @@ their corresponding top-level category object in your `settings.json` file. integration. When enabled, tools automatically respect policy engine decisions (ALLOW/DENY/ASK_USER) without requiring individual tool implementations. - - **Default:** `false` + - **Default:** `true` - **Requires restart:** Yes - **`tools.enableHooks`** (boolean): diff --git a/packages/cli/src/config/config.test.ts b/packages/cli/src/config/config.test.ts index bfb6967bef..2ec764a991 100644 --- a/packages/cli/src/config/config.test.ts +++ b/packages/cli/src/config/config.test.ts @@ -632,6 +632,14 @@ describe('loadCliConfig', () => { DEFAULT_FILE_FILTERING_OPTIONS.respectGeminiIgnore, ); }); + + it('should default enableMessageBusIntegration to true when unconfigured', async () => { + process.argv = ['node', 'script.js']; + const argv = await parseArguments({} as Settings); + const settings: Settings = {}; + const config = await loadCliConfig(settings, 'test-session', argv); + expect(config['enableMessageBusIntegration']).toBe(true); + }); }); describe('Hierarchical Memory Loading (config.ts) - Placeholder Suite', () => { diff --git a/packages/cli/src/config/config.ts b/packages/cli/src/config/config.ts index 7625a68d5d..d55b58adc2 100755 --- a/packages/cli/src/config/config.ts +++ b/packages/cli/src/config/config.ts @@ -513,7 +513,7 @@ export async function loadCliConfig( ); const enableMessageBusIntegration = - settings.tools?.enableMessageBusIntegration ?? false; + settings.tools?.enableMessageBusIntegration ?? true; const allowedTools = argv.allowedTools || settings.tools?.allowed || []; const allowedToolsSet = new Set(allowedTools); diff --git a/packages/cli/src/config/settingsSchema.ts b/packages/cli/src/config/settingsSchema.ts index 8821deab7c..453f449697 100644 --- a/packages/cli/src/config/settingsSchema.ts +++ b/packages/cli/src/config/settingsSchema.ts @@ -1055,7 +1055,7 @@ const SETTINGS_SCHEMA = { label: 'Enable Message Bus Integration', category: 'Tools', requiresRestart: true, - default: false, + default: true, description: oneLine` Enable policy-based tool confirmation via message bus integration. When enabled, tools automatically respect policy engine decisions (ALLOW/DENY/ASK_USER) without requiring individual tool implementations. diff --git a/schemas/settings.schema.json b/schemas/settings.schema.json index dbac18cf55..ba179f888a 100644 --- a/schemas/settings.schema.json +++ b/schemas/settings.schema.json @@ -1081,8 +1081,8 @@ "enableMessageBusIntegration": { "title": "Enable Message Bus Integration", "description": "Enable policy-based tool confirmation via message bus integration. When enabled, tools automatically respect policy engine decisions (ALLOW/DENY/ASK_USER) without requiring individual tool implementations.", - "markdownDescription": "Enable policy-based tool confirmation via message bus integration. When enabled, tools automatically respect policy engine decisions (ALLOW/DENY/ASK_USER) without requiring individual tool implementations.\n\n- Category: `Tools`\n- Requires restart: `yes`\n- Default: `false`", - "default": false, + "markdownDescription": "Enable policy-based tool confirmation via message bus integration. When enabled, tools automatically respect policy engine decisions (ALLOW/DENY/ASK_USER) without requiring individual tool implementations.\n\n- Category: `Tools`\n- Requires restart: `yes`\n- Default: `true`", + "default": true, "type": "boolean" }, "enableHooks": {