diff --git a/.github/workflows/chained_e2e.yml b/.github/workflows/chained_e2e.yml index 487225d452..4b37d0e109 100644 --- a/.github/workflows/chained_e2e.yml +++ b/.github/workflows/chained_e2e.yml @@ -224,8 +224,6 @@ jobs: if: | always() && (needs.merge_queue_skipper.result !='success' || needs.merge_queue_skipper.outputs.skip != 'true') runs-on: 'gemini-cli-windows-16-core' - continue-on-error: true - steps: - name: 'Checkout' uses: 'actions/checkout@08eba0b27e820071cde6df949e0beb9ba4906955' # ratchet:actions/checkout@v5 @@ -315,6 +313,7 @@ jobs: needs: - 'e2e_linux' - 'e2e_mac' + - 'e2e_windows' - 'evals' - 'merge_queue_skipper' runs-on: 'gemini-cli-ubuntu-16-core' @@ -323,6 +322,7 @@ jobs: run: | if [[ ${{ needs.e2e_linux.result }} != 'success' || \ ${{ needs.e2e_mac.result }} != 'success' || \ + ${{ needs.e2e_windows.result }} != 'success' || \ ${{ needs.evals.result }} != 'success' ]]; then echo "One or more E2E jobs failed." exit 1 diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 0f9714df99..dd7288cde5 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -360,7 +360,6 @@ jobs: runs-on: 'gemini-cli-windows-16-core' needs: 'merge_queue_skipper' if: "${{needs.merge_queue_skipper.outputs.skip == 'false'}}" - continue-on-error: true timeout-minutes: 60 strategy: matrix: @@ -458,6 +457,7 @@ jobs: - 'link_checker' - 'test_linux' - 'test_mac' + - 'test_windows' - 'codeql' - 'bundle_size' runs-on: 'gemini-cli-ubuntu-16-core' @@ -468,6 +468,7 @@ jobs: (${{ needs.link_checker.result }} != 'success' && ${{ needs.link_checker.result }} != 'skipped') || \ (${{ needs.test_linux.result }} != 'success' && ${{ needs.test_linux.result }} != 'skipped') || \ (${{ needs.test_mac.result }} != 'success' && ${{ needs.test_mac.result }} != 'skipped') || \ + (${{ needs.test_windows.result }} != 'success' && ${{ needs.test_windows.result }} != 'skipped') || \ (${{ needs.codeql.result }} != 'success' && ${{ needs.codeql.result }} != 'skipped') || \ (${{ needs.bundle_size.result }} != 'success' && ${{ needs.bundle_size.result }} != 'skipped') ]]; then echo "One or more CI jobs failed."