Fix tests to wrap all calls changing the UI with act. (#12268)

packages/cli/src/test-utils/render.test.tsx

@@ -6,7 +6,37 @@
 
 import { describe, it, expect, vi } from 'vitest';
 import { useState, useEffect } from 'react';
-import { renderHook } from './render.js';
+import { Text } from 'ink';
+import { renderHook, render } from './render.js';
+import { waitFor } from './async.js';
+
+describe('render', () => {
+  it('should render a component', () => {
+    const { lastFrame } = render(<Text>Hello World</Text>);
+    expect(lastFrame()).toBe('Hello World');
+  });
+
+  it('should support rerender', () => {
+    const { lastFrame, rerender } = render(<Text>Hello</Text>);
+    expect(lastFrame()).toBe('Hello');
+
+    rerender(<Text>World</Text>);
+    expect(lastFrame()).toBe('World');
+  });
+
+  it('should support unmount', () => {
+    const cleanup = vi.fn();
+    function TestComponent() {
+      useEffect(() => cleanup, []);
+      return <Text>Hello</Text>;
+    }
+
+    const { unmount } = render(<TestComponent />);
+    unmount();
+
+    expect(cleanup).toHaveBeenCalled();
+  });
+});
 
 describe('renderHook', () => {
   it('should rerender with previous props when called without arguments', async () => {
@@ -23,19 +53,19 @@ describe('renderHook', () => {
     });
 
     expect(result.current.value).toBe(1);
-    await vi.waitFor(() => expect(result.current.count).toBe(1));
+    await waitFor(() => expect(result.current.count).toBe(1));
 
     // Rerender with new props
     rerender({ value: 2 });
     expect(result.current.value).toBe(2);
-    await vi.waitFor(() => expect(result.current.count).toBe(2));
+    await waitFor(() => expect(result.current.count).toBe(2));
 
     // Rerender without arguments should use previous props (value: 2)
     // This would previously crash or pass undefined if not fixed
     rerender();
     expect(result.current.value).toBe(2);
     // Count should not increase because value didn't change
-    await vi.waitFor(() => expect(result.current.count).toBe(2));
+    await waitFor(() => expect(result.current.count).toBe(2));
   });
 
   it('should handle initial render without props', () => {