mirror of
https://github.com/google-gemini/gemini-cli.git
synced 2026-05-13 05:12:55 -07:00
fix: address security and reliability issues in build_binaries.js
- Use execFileSync instead of execSync to prevent shell injection - Exit with non-zero code when builds fail for CI integrity - Capture and display stderr for better error diagnostics - Fixes CodeQL security warning about shell command injection
This commit is contained in:
@@ -4,7 +4,7 @@
|
|||||||
* SPDX-License-Identifier: Apache-2.0
|
* SPDX-License-Identifier: Apache-2.0
|
||||||
*/
|
*/
|
||||||
|
|
||||||
import { execSync } from 'child_process';
|
import { execFileSync } from 'child_process';
|
||||||
import fs from 'fs';
|
import fs from 'fs';
|
||||||
import path from 'path';
|
import path from 'path';
|
||||||
import { fileURLToPath } from 'url';
|
import { fileURLToPath } from 'url';
|
||||||
@@ -49,10 +49,15 @@ for (const { name, target } of targets) {
|
|||||||
console.log(`Building ${name}...`);
|
console.log(`Building ${name}...`);
|
||||||
|
|
||||||
try {
|
try {
|
||||||
const command = `bun build --compile --target=${target} ${bundleJs} --outfile ${outputPath}`;
|
execFileSync('bun', [
|
||||||
execSync(command, { stdio: 'pipe' });
|
'build',
|
||||||
|
'--compile',
|
||||||
|
`--target=${target}`,
|
||||||
|
bundleJs,
|
||||||
|
'--outfile',
|
||||||
|
outputPath
|
||||||
|
], { stdio: ['pipe', 'pipe', 'pipe'] });
|
||||||
|
|
||||||
// Check if file was created
|
|
||||||
if (fs.existsSync(outputPath)) {
|
if (fs.existsSync(outputPath)) {
|
||||||
const stats = fs.statSync(outputPath);
|
const stats = fs.statSync(outputPath);
|
||||||
const sizeMB = (stats.size / (1024 * 1024)).toFixed(1);
|
const sizeMB = (stats.size / (1024 * 1024)).toFixed(1);
|
||||||
@@ -64,6 +69,9 @@ for (const { name, target } of targets) {
|
|||||||
} catch (error) {
|
} catch (error) {
|
||||||
console.error(` ✗ Failed to build ${name}`);
|
console.error(` ✗ Failed to build ${name}`);
|
||||||
console.error(` ${error.message}`);
|
console.error(` ${error.message}`);
|
||||||
|
if (error.stderr) {
|
||||||
|
console.error(` ${error.stderr.toString()}`);
|
||||||
|
}
|
||||||
failedTargets.push(name);
|
failedTargets.push(name);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
@@ -81,6 +89,7 @@ if (failedTargets.length > 0) {
|
|||||||
console.log(
|
console.log(
|
||||||
'In CI, all targets should build successfully on the appropriate runner.',
|
'In CI, all targets should build successfully on the appropriate runner.',
|
||||||
);
|
);
|
||||||
|
process.exit(1);
|
||||||
}
|
}
|
||||||
|
|
||||||
console.log(`\nBinaries saved to: ${outputDir}`);
|
console.log(`\nBinaries saved to: ${outputDir}`);
|
||||||
|
|||||||
Reference in New Issue
Block a user