feat(cli): add Sublime Text and Emacs Client editors, improve error messages and documentation (#21090)

Co-authored-by: Ananth Kini <ananthkini1@gmail.com>
This commit is contained in:
Andrea Alberti
2026-05-19 22:03:25 +02:00
committed by GitHub
parent 8997488ea6
commit 57c42a5c40
11 changed files with 527 additions and 85 deletions
@@ -22,7 +22,6 @@ import {
type EditorType,
isEditorAvailable,
EDITOR_DISPLAY_NAMES,
coreEvents,
} from '@google/gemini-cli-core';
import { useKeypress } from '../hooks/useKeypress.js';
@@ -72,10 +71,6 @@ export function EditorSettingsDialog({
)
: 0;
if (editorIndex === -1) {
coreEvents.emitFeedback(
'error',
`Editor is not supported: ${currentPreference}`,
);
editorIndex = 0;
}
@@ -131,10 +126,7 @@ export function EditorSettingsDialog({
isEditorAvailable(settings.merged.general.preferredEditor)
) {
mergedEditorName =
EDITOR_DISPLAY_NAMES[
// eslint-disable-next-line @typescript-eslint/no-unsafe-type-assertion
settings.merged.general.preferredEditor as EditorType
];
EDITOR_DISPLAY_NAMES[settings.merged.general.preferredEditor];
}
return (
@@ -161,6 +153,7 @@ export function EditorSettingsDialog({
onSelect={handleEditorSelect}
isFocused={focusedSection === 'editor'}
key={selectedScope}
maxItemsToShow={editorItems.length}
/>
<Box marginTop={1} flexDirection="column">