From 5b2ad83372dab4a8e6251b08733792e6b6cfde84 Mon Sep 17 00:00:00 2001 From: mkorwel Date: Tue, 21 Oct 2025 22:44:53 -0700 Subject: [PATCH] refactor(build): Remove redundant lint job and dependency Removes the redundant 'lint' job from 'build-and-publish.yml'. This job was duplicating the linting efforts now handled by the dedicated 'lint.yml' workflow. The 'publish-bundle' job no longer declares an internal dependency on 'lint', as the orchestrator workflow ensures linting is completed before calling 'build-and-publish'. --- .github/workflows/build-and-publish.yml | 47 ------------------------- 1 file changed, 47 deletions(-) diff --git a/.github/workflows/build-and-publish.yml b/.github/workflows/build-and-publish.yml index 28b5cca1c2..1b6a34b52a 100644 --- a/.github/workflows/build-and-publish.yml +++ b/.github/workflows/build-and-publish.yml @@ -9,56 +9,9 @@ on: value: '${{ jobs.publish-bundle.outputs.version }}' jobs: - lint: - name: 'Lint' - runs-on: 'gemini-cli-ubuntu-16-core' - steps: - - name: 'Checkout' - uses: 'actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8' # ratchet:actions/checkout@v5 - with: - ref: '${{ github.event.inputs.branch_ref || github.ref }}' - fetch-depth: 0 - - - name: 'Set up Node.js' - uses: 'actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020' # ratchet:actions/setup-node@v4.4.0 - with: - node-version-file: '.nvmrc' - cache: 'npm' - - - name: 'Install dependencies' - run: 'npm ci' - - - name: 'Validate NOTICES.txt' - run: 'git diff --exit-code packages/vscode-ide-companion/NOTICES.txt' - - - name: 'Check lockfile' - run: 'npm run check:lockfile' - - - name: 'Install linters' - run: 'node scripts/lint.js --setup' - - - name: 'Run ESLint' - run: 'node scripts/lint.js --eslint' - - - name: 'Run actionlint' - run: 'node scripts/lint.js --actionlint' - - - name: 'Run shellcheck' - run: 'node scripts/lint.js --shellcheck' - - - name: 'Run yamllint' - run: 'node scripts/lint.js --yamllint' - - - name: 'Run Prettier' - run: 'node scripts/lint.js --prettier' - - - name: 'Run sensitive keyword linter' - run: 'node scripts/lint.js --sensitive-keywords' - publish-bundle: name: 'Publish Bundle' runs-on: 'gemini-cli-ubuntu-16-core' - needs: ['lint'] outputs: version: '${{ steps.version.outputs.version }}' permissions: