MediaMetz/gemini-cli
1
0
Fork 0
mirror of https://github.com/google-gemini/gemini-cli.git synced 2026-04-22 19:14:33 -07:00
Code Issues Packages Projects Releases Wiki Activity

refactor(core): replace positional execute params with ExecuteOptions bag (#22674)

Browse Source
This commit is contained in:
Adam Weidman
2026-03-16 17:50:24 -04:00
committed by GitHub
parent 990d010ecf
commit 605432ea70
10 changed files with 50 additions and 50 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/core/src/scheduler/tool-executor.test.ts
+5 -14
View File
@@ -570,14 +570,13 @@ describe('ToolExecutor', () => {
_sig,
_tool,
_liveCb,
_shellCfg,
setExecutionIdCallback,
options,
_config,
_originalRequestName,
) => {
// Simulate the tool reporting an execution ID
if (setExecutionIdCallback) {
setExecutionIdCallback(testPid);
if (options?.setExecutionIdCallback) {
options.setExecutionIdCallback(testPid);
}
return { llmContent: 'done', returnDisplay: 'done' };
},
@@ -624,16 +623,8 @@ describe('ToolExecutor', () => {
const testExecutionId = 67890;
vi.mocked(coreToolHookTriggers.executeToolWithHooks).mockImplementation(
async (
_inv,
_name,
_sig,
_tool,
_liveCb,
_shellCfg,
setExecutionIdCallback,
) => {
setExecutionIdCallback?.(testExecutionId);
async (_inv, _name, _sig, _tool, _liveCb, options) => {
options?.setExecutionIdCallback?.(testExecutionId);
return { llmContent: 'done', returnDisplay: 'done' };
},
);