MediaMetz/gemini-cli
1
0
Fork 0
mirror of https://github.com/google-gemini/gemini-cli.git synced 2026-04-18 17:20:38 -07:00
Code Issues Packages Projects Releases Wiki Activity

feat(settings): rename negative settings to positive naming (disable* -> enable*) (#14142)

Browse Source 
Co-authored-by: jacob314 <jacob314@gmail.com>
This commit is contained in:
Alexander Farber
2026-01-16 23:33:49 +01:00
committed by GitHub
parent f2d3b76389
commit 608da23393
25 changed files with 785 additions and 243 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
packages/cli/src/ui/components/Composer.test.tsx
View File

@@ -283,7 +283,7 @@ describe('Composer', () => {
thought: { subject: 'Hidden', description: 'Should not show' },
});
const config = createMockConfig({
getAccessibility: vi.fn(() => ({ disableLoadingPhrases: true })),
getAccessibility: vi.fn(() => ({ enableLoadingPhrases: false })),
});
const { lastFrame } = renderComposer(uiState, undefined, config);

4
packages/cli/src/ui/components/Composer.tsx
View File

@@ -58,12 +58,12 @@ export const Composer = () => {
<LoadingIndicator
thought={
uiState.streamingState === StreamingState.WaitingForConfirmation ||
config.getAccessibility()?.disableLoadingPhrases
config.getAccessibility()?.enableLoadingPhrases === false
? undefined
: uiState.thought
}
currentLoadingPhrase={
config.getAccessibility()?.disableLoadingPhrases
config.getAccessibility()?.enableLoadingPhrases === false
? undefined
: uiState.currentLoadingPhrase
}

28
packages/cli/src/ui/components/SettingsDialog.test.tsx
View File

@@ -320,9 +320,9 @@ describe('SettingsDialog', () => {
// 'general.vimMode' has description 'Enable Vim keybindings' in settingsSchema.ts
expect(output).toContain('Vim Mode');
expect(output).toContain('Enable Vim keybindings');
// 'general.disableAutoUpdate' has description 'Disable automatic updates'
expect(output).toContain('Disable Auto Update');
expect(output).toContain('Disable automatic updates');
// 'general.enableAutoUpdate' has description 'Enable automatic updates.'
expect(output).toContain('Enable Auto Update');
expect(output).toContain('Enable automatic updates.');
});
});
@@ -353,7 +353,7 @@ describe('SettingsDialog', () => {
});
await waitFor(() => {
expect(lastFrame()).toContain('Disable Auto Update');
expect(lastFrame()).toContain('Enable Auto Update');
});
// Navigate up
@@ -1236,7 +1236,7 @@ describe('SettingsDialog', () => {
expect(lastFrame()).toContain('nonexistentsetting');
expect(lastFrame()).toContain('');
expect(lastFrame()).not.toContain('Vim Mode'); // Should not contain any settings
expect(lastFrame()).not.toContain('Disable Auto Update'); // Should not contain any settings
expect(lastFrame()).not.toContain('Enable Auto Update'); // Should not contain any settings
});
unmount();
@@ -1263,7 +1263,7 @@ describe('SettingsDialog', () => {
userSettings: {
general: {
vimMode: true,
disableAutoUpdate: true,
enableAutoUpdate: false,
debugKeystrokeLogging: true,
enablePromptCompletion: true,
},
@@ -1274,7 +1274,7 @@ describe('SettingsDialog', () => {
showLineNumbers: true,
showCitations: true,
accessibility: {
disableLoadingPhrases: true,
enableLoadingPhrases: false,
screenReader: true,
},
},
@@ -1287,7 +1287,7 @@ describe('SettingsDialog', () => {
respectGitIgnore: true,
respectGeminiIgnore: true,
enableRecursiveFileSearch: true,
disableFuzzySearch: false,
enableFuzzySearch: true,
},
},
tools: {
@@ -1310,7 +1310,7 @@ describe('SettingsDialog', () => {
userSettings: {
general: {
vimMode: false,
disableAutoUpdate: true,
enableAutoUpdate: false,
},
ui: {
showMemoryUsage: true,
@@ -1348,7 +1348,7 @@ describe('SettingsDialog', () => {
userSettings: {
ui: {
accessibility: {
disableLoadingPhrases: true,
enableLoadingPhrases: false,
screenReader: true,
},
showMemoryUsage: true,
@@ -1370,7 +1370,7 @@ describe('SettingsDialog', () => {
respectGitIgnore: false,
respectGeminiIgnore: true,
enableRecursiveFileSearch: false,
disableFuzzySearch: true,
enableFuzzySearch: false,
},
loadMemoryFromIncludeDirectories: true,
discoveryMaxDirs: 100,
@@ -1409,7 +1409,7 @@ describe('SettingsDialog', () => {
userSettings: {
general: {
vimMode: false,
disableAutoUpdate: false,
enableAutoUpdate: true,
debugKeystrokeLogging: false,
enablePromptCompletion: false,
},
@@ -1420,7 +1420,7 @@ describe('SettingsDialog', () => {
showLineNumbers: false,
showCitations: false,
accessibility: {
disableLoadingPhrases: false,
enableLoadingPhrases: true,
screenReader: false,
},
},
@@ -1433,7 +1433,7 @@ describe('SettingsDialog', () => {
respectGitIgnore: false,
respectGeminiIgnore: false,
enableRecursiveFileSearch: false,
disableFuzzySearch: false,
enableFuzzySearch: true,
},
},
tools: {

36
packages/cli/src/ui/components/__snapshots__/SettingsDialog.test.tsx.snap
View File

@@ -16,8 +16,8 @@ exports[`SettingsDialog > Initial Rendering > should render settings list with v
│ Vim Mode false │
│ Enable Vim keybindings │
│ │
│ Disable Auto Update false │
│ Disable automatic updates │
│ Enable Auto Update true │
│ Enable automatic updates. │
│ │
│ Enable Prompt Completion false │
│ Enable AI-powered prompt completion suggestions while typing. │
@@ -62,8 +62,8 @@ exports[`SettingsDialog > Snapshot Tests > should render 'accessibility settings
│ Vim Mode true* │
│ Enable Vim keybindings │
│ │
│ Disable Auto Update false │
│ Disable automatic updates │
│ Enable Auto Update true │
│ Enable automatic updates. │
│ │
│ Enable Prompt Completion false │
│ Enable AI-powered prompt completion suggestions while typing. │
@@ -108,8 +108,8 @@ exports[`SettingsDialog > Snapshot Tests > should render 'all boolean settings d
│ Vim Mode false* │
│ Enable Vim keybindings │
│ │
│ Disable Auto Update false* │
│ Disable automatic updates │
│ Enable Auto Update true* │
│ Enable automatic updates. │
│ │
│ Enable Prompt Completion false* │
│ Enable AI-powered prompt completion suggestions while typing. │
@@ -154,8 +154,8 @@ exports[`SettingsDialog > Snapshot Tests > should render 'default state' correct
│ Vim Mode false │
│ Enable Vim keybindings │
│ │
│ Disable Auto Update false │
│ Disable automatic updates │
│ Enable Auto Update true │
│ Enable automatic updates. │
│ │
│ Enable Prompt Completion false │
│ Enable AI-powered prompt completion suggestions while typing. │
@@ -200,8 +200,8 @@ exports[`SettingsDialog > Snapshot Tests > should render 'file filtering setting
│ Vim Mode false │
│ Enable Vim keybindings │
│ │
│ Disable Auto Update false │
│ Disable automatic updates │
│ Enable Auto Update true │
│ Enable automatic updates. │
│ │
│ Enable Prompt Completion false │
│ Enable AI-powered prompt completion suggestions while typing. │
@@ -246,8 +246,8 @@ exports[`SettingsDialog > Snapshot Tests > should render 'focused on scope selec
│ Vim Mode false │
│ Enable Vim keybindings │
│ │
│ Disable Auto Update false │
│ Disable automatic updates │
│ Enable Auto Update true │
│ Enable automatic updates. │
│ │
│ Enable Prompt Completion false │
│ Enable AI-powered prompt completion suggestions while typing. │
@@ -292,8 +292,8 @@ exports[`SettingsDialog > Snapshot Tests > should render 'mixed boolean and numb
│ Vim Mode false* │
│ Enable Vim keybindings │
│ │
│ Disable Auto Update true* │
│ Disable automatic updates │
│ Enable Auto Update false* │
│ Enable automatic updates. │
│ │
│ Enable Prompt Completion false │
│ Enable AI-powered prompt completion suggestions while typing. │
@@ -338,8 +338,8 @@ exports[`SettingsDialog > Snapshot Tests > should render 'tools and security set
│ Vim Mode false │
│ Enable Vim keybindings │
│ │
│ Disable Auto Update false │
│ Disable automatic updates │
│ Enable Auto Update true │
│ Enable automatic updates. │
│ │
│ Enable Prompt Completion false │
│ Enable AI-powered prompt completion suggestions while typing. │
@@ -384,8 +384,8 @@ exports[`SettingsDialog > Snapshot Tests > should render 'various boolean settin
│ Vim Mode true* │
│ Enable Vim keybindings │
│ │
│ Disable Auto Update true* │
│ Disable automatic updates │
│ Enable Auto Update false* │
│ Enable automatic updates. │
│ │
│ Enable Prompt Completion true* │
│ Enable AI-powered prompt completion suggestions while typing. │