MediaMetz/gemini-cli
1
0
Fork 0
mirror of https://github.com/google-gemini/gemini-cli.git synced 2026-04-24 03:54:43 -07:00
Code Issues Packages Projects Releases Wiki Activity

feat(settings): rename negative settings to positive naming (disable* -> enable*) (#14142)

Browse Source 
Co-authored-by: jacob314 <jacob314@gmail.com>
This commit is contained in:
Alexander Farber
2026-01-16 23:33:49 +01:00
committed by GitHub
parent f2d3b76389
commit 608da23393
25 changed files with 785 additions and 243 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/cli/src/ui/components/SettingsDialog.test.tsx
+14 -14
View File
@@ -320,9 +320,9 @@ describe('SettingsDialog', () => {
// 'general.vimMode' has description 'Enable Vim keybindings' in settingsSchema.ts
expect(output).toContain('Vim Mode');
expect(output).toContain('Enable Vim keybindings');
// 'general.disableAutoUpdate' has description 'Disable automatic updates'
expect(output).toContain('Disable Auto Update');
expect(output).toContain('Disable automatic updates');
// 'general.enableAutoUpdate' has description 'Enable automatic updates.'
expect(output).toContain('Enable Auto Update');
expect(output).toContain('Enable automatic updates.');
});
});
@@ -353,7 +353,7 @@ describe('SettingsDialog', () => {
});
await waitFor(() => {
expect(lastFrame()).toContain('Disable Auto Update');
expect(lastFrame()).toContain('Enable Auto Update');
});
// Navigate up
@@ -1236,7 +1236,7 @@ describe('SettingsDialog', () => {
expect(lastFrame()).toContain('nonexistentsetting');
expect(lastFrame()).toContain('');
expect(lastFrame()).not.toContain('Vim Mode'); // Should not contain any settings
expect(lastFrame()).not.toContain('Disable Auto Update'); // Should not contain any settings
expect(lastFrame()).not.toContain('Enable Auto Update'); // Should not contain any settings
});
unmount();
@@ -1263,7 +1263,7 @@ describe('SettingsDialog', () => {
userSettings: {
general: {
vimMode: true,
disableAutoUpdate: true,
enableAutoUpdate: false,
debugKeystrokeLogging: true,
enablePromptCompletion: true,
},
@@ -1274,7 +1274,7 @@ describe('SettingsDialog', () => {
showLineNumbers: true,
showCitations: true,
accessibility: {
disableLoadingPhrases: true,
enableLoadingPhrases: false,
screenReader: true,
},
},
@@ -1287,7 +1287,7 @@ describe('SettingsDialog', () => {
respectGitIgnore: true,
respectGeminiIgnore: true,
enableRecursiveFileSearch: true,
disableFuzzySearch: false,
enableFuzzySearch: true,
},
},
tools: {
@@ -1310,7 +1310,7 @@ describe('SettingsDialog', () => {
userSettings: {
general: {
vimMode: false,
disableAutoUpdate: true,
enableAutoUpdate: false,
},
ui: {
showMemoryUsage: true,
@@ -1348,7 +1348,7 @@ describe('SettingsDialog', () => {
userSettings: {
ui: {
accessibility: {
disableLoadingPhrases: true,
enableLoadingPhrases: false,
screenReader: true,
},
showMemoryUsage: true,
@@ -1370,7 +1370,7 @@ describe('SettingsDialog', () => {
respectGitIgnore: false,
respectGeminiIgnore: true,
enableRecursiveFileSearch: false,
disableFuzzySearch: true,
enableFuzzySearch: false,
},
loadMemoryFromIncludeDirectories: true,
discoveryMaxDirs: 100,
@@ -1409,7 +1409,7 @@ describe('SettingsDialog', () => {
userSettings: {
general: {
vimMode: false,
disableAutoUpdate: false,
enableAutoUpdate: true,
debugKeystrokeLogging: false,
enablePromptCompletion: false,
},
@@ -1420,7 +1420,7 @@ describe('SettingsDialog', () => {
showLineNumbers: false,
showCitations: false,
accessibility: {
disableLoadingPhrases: false,
enableLoadingPhrases: true,
screenReader: false,
},
},
@@ -1433,7 +1433,7 @@ describe('SettingsDialog', () => {
respectGitIgnore: false,
respectGeminiIgnore: false,
enableRecursiveFileSearch: false,
disableFuzzySearch: false,
enableFuzzySearch: true,
},
},
tools: {