MediaMetz/gemini-cli
1
0
Fork 0
mirror of https://github.com/google-gemini/gemini-cli.git synced 2026-04-09 04:41:19 -07:00
Code Issues Packages Projects Releases Wiki Activity

feat(settings): rename negative settings to positive naming (disable* -> enable*) (#14142)

Browse Source 
Co-authored-by: jacob314 <jacob314@gmail.com>
This commit is contained in:
Alexander Farber
2026-01-16 23:33:49 +01:00
committed by GitHub
parent f2d3b76389
commit 608da23393
25 changed files with 785 additions and 243 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
packages/cli/src/ui/utils/updateCheck.test.ts
View File

@@ -34,7 +34,7 @@ describe('checkForUpdates', () => {
mockSettings = {
merged: {
general: {
disableUpdateNag: false,
enableAutoUpdateNotification: true,
},
},
} as LoadedSettings;
@@ -45,8 +45,8 @@ describe('checkForUpdates', () => {
vi.restoreAllMocks();
});
it('should return null if disableUpdateNag is true', async () => {
mockSettings.merged.general.disableUpdateNag = true;
it('should return null if enableAutoUpdateNotification is false', async () => {
mockSettings.merged.general.enableAutoUpdateNotification = false;
const result = await checkForUpdates(mockSettings);
expect(result).toBeNull();
expect(getPackageJson).not.toHaveBeenCalled();

2
packages/cli/src/ui/utils/updateCheck.ts
View File

@@ -51,7 +51,7 @@ export async function checkForUpdates(
settings: LoadedSettings,
): Promise<UpdateObject | null> {
try {
if (settings.merged.general.disableUpdateNag) {
if (!settings.merged.general.enableAutoUpdateNotification) {
return null;
}
// Skip update check when running from source (development mode)