feat(settings): rename negative settings to positive naming (disable* -> enable*) (#14142)

Co-authored-by: jacob314 <jacob314@gmail.com>

packages/core/src/config/config.ts

@@ -108,7 +108,7 @@ import type { AgentDefinition } from '../agents/types.js';
 import { fetchAdminControls } from '../code_assist/admin/admin_controls.js';
 
 export interface AccessibilitySettings {
-  disableLoadingPhrases?: boolean;
+  enableLoadingPhrases?: boolean;
   screenReader?: boolean;
 }
 
@@ -311,7 +311,7 @@ export interface ConfigParameters {
     respectGitIgnore?: boolean;
     respectGeminiIgnore?: boolean;
     enableRecursiveFileSearch?: boolean;
-    disableFuzzySearch?: boolean;
+    enableFuzzySearch?: boolean;
     maxFileCount?: number;
     searchTimeout?: number;
   };
@@ -444,7 +444,7 @@ export class Config {
     respectGitIgnore: boolean;
     respectGeminiIgnore: boolean;
     enableRecursiveFileSearch: boolean;
-    disableFuzzySearch: boolean;
+    enableFuzzySearch: boolean;
     maxFileCount: number;
     searchTimeout: number;
   };
@@ -598,7 +598,7 @@ export class Config {
         DEFAULT_FILE_FILTERING_OPTIONS.respectGeminiIgnore,
       enableRecursiveFileSearch:
         params.fileFiltering?.enableRecursiveFileSearch ?? true,
-      disableFuzzySearch: params.fileFiltering?.disableFuzzySearch ?? false,
+      enableFuzzySearch: params.fileFiltering?.enableFuzzySearch ?? true,
       maxFileCount:
         params.fileFiltering?.maxFileCount ??
         DEFAULT_FILE_FILTERING_OPTIONS.maxFileCount ??
@@ -1402,8 +1402,8 @@ export class Config {
     return this.fileFiltering.enableRecursiveFileSearch;
   }
 
-  getFileFilteringDisableFuzzySearch(): boolean {
-    return this.fileFiltering.disableFuzzySearch;
+  getFileFilteringEnableFuzzySearch(): boolean {
+    return this.fileFiltering.enableFuzzySearch;
   }
 
   getFileFilteringRespectGitIgnore(): boolean {

packages/core/src/utils/filesearch/fileSearch.test.ts

@@ -33,7 +33,7 @@ describe('FileSearch', () => {
       cache: false,
       cacheTtl: 0,
       enableRecursiveFileSearch: true,
-      disableFuzzySearch: false,
+      enableFuzzySearch: true,
     });
 
     await fileSearch.initialize();
@@ -59,7 +59,7 @@ describe('FileSearch', () => {
       cache: false,
       cacheTtl: 0,
       enableRecursiveFileSearch: true,
-      disableFuzzySearch: false,
+      enableFuzzySearch: true,
     });
 
     await fileSearch.initialize();
@@ -87,7 +87,7 @@ describe('FileSearch', () => {
       cache: false,
       cacheTtl: 0,
       enableRecursiveFileSearch: true,
-      disableFuzzySearch: false,
+      enableFuzzySearch: true,
     });
 
     await fileSearch.initialize();
@@ -116,7 +116,7 @@ describe('FileSearch', () => {
       cache: false,
       cacheTtl: 0,
       enableRecursiveFileSearch: true,
-      disableFuzzySearch: false,
+      enableFuzzySearch: true,
     });
 
     await fileSearch.initialize();
@@ -149,7 +149,7 @@ describe('FileSearch', () => {
       cache: false,
       cacheTtl: 0,
       enableRecursiveFileSearch: true,
-      disableFuzzySearch: false,
+      enableFuzzySearch: true,
     });
 
     await fileSearch.initialize();
@@ -173,7 +173,7 @@ describe('FileSearch', () => {
       cache: false,
       cacheTtl: 0,
       enableRecursiveFileSearch: true,
-      disableFuzzySearch: false,
+      enableFuzzySearch: true,
     });
 
     await fileSearch.initialize();
@@ -208,7 +208,7 @@ describe('FileSearch', () => {
       cache: false,
       cacheTtl: 0,
       enableRecursiveFileSearch: true,
-      disableFuzzySearch: false,
+      enableFuzzySearch: true,
     });
 
     await fileSearch.initialize();
@@ -238,7 +238,7 @@ describe('FileSearch', () => {
       cache: false,
       cacheTtl: 0,
       enableRecursiveFileSearch: true,
-      disableFuzzySearch: false,
+      enableFuzzySearch: true,
     });
 
     await fileSearch.initialize();
@@ -268,7 +268,7 @@ describe('FileSearch', () => {
       cache: false,
       cacheTtl: 0,
       enableRecursiveFileSearch: true,
-      disableFuzzySearch: false,
+      enableFuzzySearch: true,
     });
 
     // Expect no errors to be thrown during initialization
@@ -295,7 +295,7 @@ describe('FileSearch', () => {
       cache: false,
       cacheTtl: 0,
       enableRecursiveFileSearch: true,
-      disableFuzzySearch: false,
+      enableFuzzySearch: true,
     });
 
     await fileSearch.initialize();
@@ -321,7 +321,7 @@ describe('FileSearch', () => {
       cache: false,
       cacheTtl: 0,
       enableRecursiveFileSearch: true,
-      disableFuzzySearch: false,
+      enableFuzzySearch: true,
     });
 
     await fileSearch.initialize();
@@ -330,7 +330,7 @@ describe('FileSearch', () => {
     expect(results).toEqual(['src/style.css']);
   });
 
-  it('should not use fzf for fuzzy matching when disableFuzzySearch is true', async () => {
+  it('should not use fzf for fuzzy matching when enableFuzzySearch is false', async () => {
     tmpDir = await createTmpDir({
       src: {
         'file1.js': '',
@@ -347,7 +347,7 @@ describe('FileSearch', () => {
       cache: false,
       cacheTtl: 0,
       enableRecursiveFileSearch: true,
-      disableFuzzySearch: true,
+      enableFuzzySearch: false,
     });
 
     await fileSearch.initialize();
@@ -356,7 +356,7 @@ describe('FileSearch', () => {
     expect(results).toEqual(['src/flexible.js']);
   });
 
-  it('should use fzf for fuzzy matching when disableFuzzySearch is false', async () => {
+  it('should use fzf for fuzzy matching when enableFuzzySearch is true', async () => {
     tmpDir = await createTmpDir({
       src: {
         'file1.js': '',
@@ -373,7 +373,7 @@ describe('FileSearch', () => {
       cache: false,
       cacheTtl: 0,
       enableRecursiveFileSearch: true,
-      disableFuzzySearch: false,
+      enableFuzzySearch: true,
     });
 
     await fileSearch.initialize();
@@ -397,7 +397,7 @@ describe('FileSearch', () => {
       cache: false,
       cacheTtl: 0,
       enableRecursiveFileSearch: true,
-      disableFuzzySearch: false,
+      enableFuzzySearch: true,
     });
 
     await fileSearch.initialize();
@@ -428,7 +428,7 @@ describe('FileSearch', () => {
       cache: false,
       cacheTtl: 0,
       enableRecursiveFileSearch: true,
-      disableFuzzySearch: false,
+      enableFuzzySearch: true,
     });
 
     await expect(fileSearch.search('')).rejects.toThrow(
@@ -450,7 +450,7 @@ describe('FileSearch', () => {
       cache: false,
       cacheTtl: 0,
       enableRecursiveFileSearch: true,
-      disableFuzzySearch: false,
+      enableFuzzySearch: true,
     });
 
     await fileSearch.initialize();
@@ -473,7 +473,7 @@ describe('FileSearch', () => {
       cache: false,
       cacheTtl: 0,
       enableRecursiveFileSearch: true,
-      disableFuzzySearch: false,
+      enableFuzzySearch: true,
     });
 
     await fileSearch.initialize();
@@ -497,7 +497,7 @@ describe('FileSearch', () => {
       cache: false,
       cacheTtl: 0,
       enableRecursiveFileSearch: true,
-      disableFuzzySearch: false,
+      enableFuzzySearch: true,
     });
 
     await fileSearch.initialize();
@@ -524,7 +524,7 @@ describe('FileSearch', () => {
       cache: false,
       cacheTtl: 0,
       enableRecursiveFileSearch: true,
-      disableFuzzySearch: false,
+      enableFuzzySearch: true,
     });
 
     await fileSearch.initialize();
@@ -561,7 +561,7 @@ describe('FileSearch', () => {
       cache: true, // Enable caching for this test
       cacheTtl: 0,
       enableRecursiveFileSearch: true,
-      disableFuzzySearch: false,
+      enableFuzzySearch: true,
     });
 
     await fileSearch.initialize();
@@ -601,7 +601,7 @@ describe('FileSearch', () => {
       cache: false,
       cacheTtl: 0,
       enableRecursiveFileSearch: true,
-      disableFuzzySearch: false,
+      enableFuzzySearch: true,
     });
 
     await fileSearch.initialize();
@@ -645,7 +645,7 @@ describe('FileSearch', () => {
       cache: true, // Ensure caching is enabled
       cacheTtl: 10000,
       enableRecursiveFileSearch: true,
-      disableFuzzySearch: false,
+      enableFuzzySearch: true,
     });
 
     await fileSearch.initialize();
@@ -683,7 +683,7 @@ describe('FileSearch', () => {
       cache: false,
       cacheTtl: 0,
       enableRecursiveFileSearch: true,
-      disableFuzzySearch: false,
+      enableFuzzySearch: true,
     });
 
     await fileSearch.initialize();
@@ -713,7 +713,7 @@ describe('FileSearch', () => {
         cache: false,
         cacheTtl: 0,
         enableRecursiveFileSearch: false,
-        disableFuzzySearch: false,
+        enableFuzzySearch: true,
       });
 
       await fileSearch.initialize();
@@ -738,7 +738,7 @@ describe('FileSearch', () => {
         cache: false,
         cacheTtl: 0,
         enableRecursiveFileSearch: false,
-        disableFuzzySearch: false,
+        enableFuzzySearch: true,
       });
 
       await fileSearch.initialize();
@@ -763,7 +763,7 @@ describe('FileSearch', () => {
         cache: false,
         cacheTtl: 0,
         enableRecursiveFileSearch: false,
-        disableFuzzySearch: false,
+        enableFuzzySearch: true,
       });
 
       await fileSearch.initialize();
@@ -786,7 +786,7 @@ describe('FileSearch', () => {
         cache: false,
         cacheTtl: 0,
         enableRecursiveFileSearch: false,
-        disableFuzzySearch: false,
+        enableFuzzySearch: true,
       });
 
       await fileSearch.initialize();

packages/core/src/utils/filesearch/fileSearch.ts

@@ -22,7 +22,7 @@ export interface FileSearchOptions {
   cache: boolean;
   cacheTtl: number;
   enableRecursiveFileSearch: boolean;
-  disableFuzzySearch: boolean;
+  enableFuzzySearch: boolean;
   maxDepth?: number;
   maxFiles?: number;
 }
@@ -122,7 +122,7 @@ class RecursiveFileSearch implements FileSearch {
   ): Promise<string[]> {
     if (
       !this.resultCache ||
-      (!this.fzf && !this.options.disableFuzzySearch) ||
+      (!this.fzf && this.options.enableFuzzySearch) ||
       !this.ignore
     ) {
       throw new Error('Engine not initialized. Call initialize() first.');
@@ -183,7 +183,7 @@ class RecursiveFileSearch implements FileSearch {
 
   private buildResultCache(): void {
     this.resultCache = new ResultCache(this.allFiles);
-    if (!this.options.disableFuzzySearch) {
+    if (this.options.enableFuzzySearch) {
       // The v1 algorithm is much faster since it only looks at the first
       // occurrence of the pattern. We use it for search spaces that have >20k
       // files, because the v2 algorithm is just too slow in those cases.