feat(core): Remove legacy settings. (#17244)

packages/cli/src/config/settings.ts

@@ -804,6 +804,14 @@ export function migrateDeprecatedSettings(
         anyModified = true;
       }
     }
+
+    // Migrate experimental agent settings
+    anyModified ||= migrateExperimentalSettings(
+      settings,
+      loadedSettings,
+      scope,
+      removeDeprecated,
+    );
   };
 
   processScope(SettingScope.User);
@@ -852,3 +860,100 @@ export function saveModelChange(
     );
   }
 }
+
+function migrateExperimentalSettings(
+  settings: Settings,
+  loadedSettings: LoadedSettings,
+  scope: LoadableSettingScope,
+  removeDeprecated: boolean,
+): boolean {
+  const experimentalSettings = settings.experimental as
+    | Record<string, unknown>
+    | undefined;
+  if (experimentalSettings) {
+    const agentsSettings = {
+      ...(settings.agents as Record<string, unknown> | undefined),
+    };
+    const agentsOverrides = {
+      ...((agentsSettings['overrides'] as Record<string, unknown>) || {}),
+    };
+    let modified = false;
+
+    // Migrate codebaseInvestigatorSettings -> agents.overrides.codebase_investigator
+    if (experimentalSettings['codebaseInvestigatorSettings']) {
+      const old = experimentalSettings[
+        'codebaseInvestigatorSettings'
+      ] as Record<string, unknown>;
+      const override = {
+        ...(agentsOverrides['codebase_investigator'] as
+          | Record<string, unknown>
+          | undefined),
+      };
+
+      if (old['enabled'] !== undefined) override['enabled'] = old['enabled'];
+
+      const runConfig = {
+        ...(override['runConfig'] as Record<string, unknown> | undefined),
+      };
+      if (old['maxNumTurns'] !== undefined)
+        runConfig['maxTurns'] = old['maxNumTurns'];
+      if (old['maxTimeMinutes'] !== undefined)
+        runConfig['maxTimeMinutes'] = old['maxTimeMinutes'];
+      if (Object.keys(runConfig).length > 0) override['runConfig'] = runConfig;
+
+      if (old['model'] !== undefined || old['thinkingBudget'] !== undefined) {
+        const modelConfig = {
+          ...(override['modelConfig'] as Record<string, unknown> | undefined),
+        };
+        if (old['model'] !== undefined) modelConfig['model'] = old['model'];
+        if (old['thinkingBudget'] !== undefined) {
+          const generateContentConfig = {
+            ...(modelConfig['generateContentConfig'] as
+              | Record<string, unknown>
+              | undefined),
+          };
+          const thinkingConfig = {
+            ...(generateContentConfig['thinkingConfig'] as
+              | Record<string, unknown>
+              | undefined),
+          };
+          thinkingConfig['thinkingBudget'] = old['thinkingBudget'];
+          generateContentConfig['thinkingConfig'] = thinkingConfig;
+          modelConfig['generateContentConfig'] = generateContentConfig;
+        }
+        override['modelConfig'] = modelConfig;
+      }
+
+      agentsOverrides['codebase_investigator'] = override;
+      modified = true;
+    }
+
+    // Migrate cliHelpAgentSettings -> agents.overrides.cli_help
+    if (experimentalSettings['cliHelpAgentSettings']) {
+      const old = experimentalSettings['cliHelpAgentSettings'] as Record<
+        string,
+        unknown
+      >;
+      const override = {
+        ...(agentsOverrides['cli_help'] as Record<string, unknown> | undefined),
+      };
+      if (old['enabled'] !== undefined) override['enabled'] = old['enabled'];
+      agentsOverrides['cli_help'] = override;
+      modified = true;
+    }
+
+    if (modified) {
+      agentsSettings['overrides'] = agentsOverrides;
+      loadedSettings.setValue(scope, 'agents', agentsSettings);
+
+      if (removeDeprecated) {
+        const newExperimental = { ...experimentalSettings };
+        delete newExperimental['codebaseInvestigatorSettings'];
+        delete newExperimental['cliHelpAgentSettings'];
+        loadedSettings.setValue(scope, 'experimental', newExperimental);
+      }
+      return true;
+    }
+  }
+  return false;
+}