From 6391c4c0f13e6572687dc61eb8b59d9cd64da43b Mon Sep 17 00:00:00 2001 From: Tommaso Sciortino Date: Tue, 16 Sep 2025 19:40:51 -0700 Subject: [PATCH] Show Citations by default for all users. (#8570) --- docs/cli/configuration.md | 2 +- packages/cli/src/ui/hooks/useGeminiStream.ts | 11 ++++------- 2 files changed, 5 insertions(+), 8 deletions(-) diff --git a/docs/cli/configuration.md b/docs/cli/configuration.md index 039dbdab7f..1fe4df4788 100644 --- a/docs/cli/configuration.md +++ b/docs/cli/configuration.md @@ -119,7 +119,7 @@ Settings are organized into categories. All settings should be placed within the - **`ui.showCitations`** (boolean): - **Description:** Show citations for generated text in the chat. - - **Default:** `false` + - **Default:** `true` - **`ui.accessibility.disableLoadingPhrases`** (boolean): - **Description:** Disable loading phrases for accessibility. diff --git a/packages/cli/src/ui/hooks/useGeminiStream.ts b/packages/cli/src/ui/hooks/useGeminiStream.ts index 19c9be1aaf..4ce58c6731 100644 --- a/packages/cli/src/ui/hooks/useGeminiStream.ts +++ b/packages/cli/src/ui/hooks/useGeminiStream.ts @@ -32,8 +32,6 @@ import { ApprovalMode, parseAndFormatApiError, ToolConfirmationOutcome, - getCodeAssistServer, - UserTierId, promptIdContext, } from '@google/gemini-cli-core'; import { type Part, type PartListUnion, FinishReason } from '@google/genai'; @@ -73,13 +71,12 @@ enum StreamProcessingStatus { const EDIT_TOOL_NAMES = new Set(['replace', 'write_file']); -function showCitations(settings: LoadedSettings, config: Config): boolean { +function showCitations(settings: LoadedSettings): boolean { const enabled = settings?.merged?.ui?.showCitations; if (enabled !== undefined) { return enabled; } - const server = getCodeAssistServer(config); - return (server && server.userTier !== UserTierId.FREE) ?? false; + return true; } /** @@ -537,7 +534,7 @@ export const useGeminiStream = ( const handleCitationEvent = useCallback( (text: string, userMessageTimestamp: number) => { - if (!showCitations(settings, config)) { + if (!showCitations(settings)) { return; } @@ -547,7 +544,7 @@ export const useGeminiStream = ( } addItem({ type: MessageType.INFO, text }, userMessageTimestamp); }, - [addItem, pendingHistoryItemRef, setPendingHistoryItem, settings, config], + [addItem, pendingHistoryItemRef, setPendingHistoryItem, settings], ); const handleFinishedEvent = useCallback(