MediaMetz/gemini-cli
1
0
Fork 0
mirror of https://github.com/google-gemini/gemini-cli.git synced 2026-04-20 10:10:56 -07:00
Code Issues Packages Projects Releases Wiki Activity

test(cli): refactor tests for async render utilities (#23252)

Browse Source
This commit is contained in:
Tommaso Sciortino
2026-03-20 20:08:29 +00:00
committed by GitHub
parent 86a3a913b5
commit 6c78eb7a39
198 changed files with 3592 additions and 4802 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/cli/src/ui/hooks/useFlickerDetector.test.ts
+14 -12
View File
@@ -62,51 +62,53 @@ describe('useFlickerDetector', () => {
vi.clearAllMocks();
});
it('should not record a flicker when height is less than terminal height', () => {
it('should not record a flicker when height is less than terminal height', async () => {
mockMeasureElement.mockReturnValue({ width: 80, height: 20 });
renderHook(() => useFlickerDetector(mockRef, 25));
await renderHook(() => useFlickerDetector(mockRef, 25));
expect(mockRecordFlickerFrame).not.toHaveBeenCalled();
expect(mockAppEventsEmit).not.toHaveBeenCalled();
});
it('should not record a flicker when height is equal to terminal height', () => {
it('should not record a flicker when height is equal to terminal height', async () => {
mockMeasureElement.mockReturnValue({ width: 80, height: 25 });
renderHook(() => useFlickerDetector(mockRef, 25));
await renderHook(() => useFlickerDetector(mockRef, 25));
expect(mockRecordFlickerFrame).not.toHaveBeenCalled();
expect(mockAppEventsEmit).not.toHaveBeenCalled();
});
it('should record a flicker when height is greater than terminal height and height is constrained', () => {
it('should record a flicker when height is greater than terminal height and height is constrained', async () => {
mockMeasureElement.mockReturnValue({ width: 80, height: 30 });
renderHook(() => useFlickerDetector(mockRef, 25));
await renderHook(() => useFlickerDetector(mockRef, 25));
expect(mockRecordFlickerFrame).toHaveBeenCalledTimes(1);
expect(mockRecordFlickerFrame).toHaveBeenCalledWith(mockConfig);
expect(mockAppEventsEmit).toHaveBeenCalledTimes(1);
expect(mockAppEventsEmit).toHaveBeenCalledWith(AppEvent.Flicker);
});
it('should NOT record a flicker when height is greater than terminal height but height is NOT constrained', () => {
it('should NOT record a flicker when height is greater than terminal height but height is NOT constrained', async () => {
// Override default UI state for this test
mockUseUIState.mockReturnValue({ constrainHeight: false });
mockMeasureElement.mockReturnValue({ width: 80, height: 30 });
renderHook(() => useFlickerDetector(mockRef, 25));
await renderHook(() => useFlickerDetector(mockRef, 25));
expect(mockRecordFlickerFrame).not.toHaveBeenCalled();
expect(mockAppEventsEmit).not.toHaveBeenCalled();
});
it('should not check for flicker if the ref is not set', () => {
it('should not check for flicker if the ref is not set', async () => {
mockRef.current = null;
mockMeasureElement.mockReturnValue({ width: 80, height: 30 });
renderHook(() => useFlickerDetector(mockRef, 25));
await renderHook(() => useFlickerDetector(mockRef, 25));
expect(mockMeasureElement).not.toHaveBeenCalled();
expect(mockRecordFlickerFrame).not.toHaveBeenCalled();
expect(mockAppEventsEmit).not.toHaveBeenCalled();
});
it('should re-evaluate on re-render', () => {
it('should re-evaluate on re-render', async () => {
// Start with a valid height
mockMeasureElement.mockReturnValue({ width: 80, height: 20 });
const { rerender } = renderHook(() => useFlickerDetector(mockRef, 25));
const { rerender } = await renderHook(() =>
useFlickerDetector(mockRef, 25),
);
expect(mockRecordFlickerFrame).not.toHaveBeenCalled();
// Now, simulate a re-render where the height is too great