From 6ef2a1da160f6a53d6911e2a79eba6b4d9823e70 Mon Sep 17 00:00:00 2001 From: mkorwel Date: Thu, 25 Sep 2025 20:57:29 -0700 Subject: [PATCH] chore: Always run prettier with --write in lint:all --- .github/workflows/release-patch-1-create-pr.yml | 3 +-- scripts/lint.js | 2 +- scripts/releasing/create-patch-pr.js | 4 ---- 3 files changed, 2 insertions(+), 7 deletions(-) diff --git a/.github/workflows/release-patch-1-create-pr.yml b/.github/workflows/release-patch-1-create-pr.yml index 6a0b58c383..6af5dac05e 100644 --- a/.github/workflows/release-patch-1-create-pr.yml +++ b/.github/workflows/release-patch-1-create-pr.yml @@ -52,7 +52,6 @@ jobs: - name: 'Install Script Dependencies' run: 'npm install yargs' - - name: 'Configure Git User' run: |- git config user.name "gemini-cli-robot" @@ -64,7 +63,7 @@ jobs: id: 'create_patch' env: GITHUB_TOKEN: '${{ secrets.GITHUB_TOKEN }}' - GEMINI_CLI_ROBOT_GITHUB_PAT: '${{ secrets.GEMINI_CLI_ROBOT_GITHUB_PAT }}' + GH_TOKEN: '${{ secrets.GEMINI_CLI_ROBOT_GITHUB_PAT }}' continue-on-error: true run: | # Capture output and display it in logs using tee diff --git a/scripts/lint.js b/scripts/lint.js index 363529c099..e28bc0a8b4 100644 --- a/scripts/lint.js +++ b/scripts/lint.js @@ -164,7 +164,7 @@ export function runYamllint() { export function runPrettier() { console.log('\nRunning Prettier...'); - if (!runCommand('prettier --check .')) { + if (!runCommand('prettier --write .')) { process.exit(1); } } diff --git a/scripts/releasing/create-patch-pr.js b/scripts/releasing/create-patch-pr.js index f9b17c28d6..1a32a50b21 100644 --- a/scripts/releasing/create-patch-pr.js +++ b/scripts/releasing/create-patch-pr.js @@ -214,11 +214,7 @@ The commit has been created with conflict markers for easier manual resolution. } const prCommand = `gh pr create --base ${releaseBranch} --head ${hotfixBranch} --title "${prTitle}" --body "${prBody}"`; - // Temporarily set the environment variable for the gh command. - process.env.GH_TOKEN = process.env.GEMINI_CLI_ROBOT_GITHUB_PAT; run(prCommand, dryRun); - // Unset the environment variable to avoid side effects. - delete process.env.GH_TOKEN; if (hasConflicts) { console.log(