From 706d4d4707a4d17af5c6b8bc4d4afe0942276961 Mon Sep 17 00:00:00 2001 From: Christian Gunderman Date: Mon, 13 Apr 2026 20:57:01 +0000 Subject: [PATCH] fix(core): prevent secondary crash in ModelRouterService finally block (#25333) --- packages/core/src/routing/modelRouterService.ts | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/packages/core/src/routing/modelRouterService.ts b/packages/core/src/routing/modelRouterService.ts index a62deacd31..30e2bb9f8d 100644 --- a/packages/core/src/routing/modelRouterService.ts +++ b/packages/core/src/routing/modelRouterService.ts @@ -74,7 +74,7 @@ export class ModelRouterService { */ async route(context: RoutingContext): Promise { const startTime = Date.now(); - let decision: RoutingDecision; + let decision: RoutingDecision | undefined; const [enableNumericalRouting, thresholdValue] = await Promise.all([ this.config.getNumericalRoutingEnabled(), @@ -117,10 +117,10 @@ export class ModelRouterService { ); } finally { const event = new ModelRoutingEvent( - decision!.model, - decision!.metadata.source, - decision!.metadata.latencyMs, - decision!.metadata.reasoning, + decision?.model || 'unknown', + decision?.metadata?.source || 'unknown', + decision?.metadata?.latencyMs || 0, + decision?.metadata?.reasoning, failed, error_message, this.config.getApprovalMode(),