MediaMetz/gemini-cli
1
0
Fork 0
mirror of https://github.com/google-gemini/gemini-cli.git synced 2026-04-24 12:04:56 -07:00
Code Issues Packages Projects Releases Wiki Activity

fix(core): Use shell for spawn on Windows (#9995)

Browse Source
This commit is contained in:
Gal Zahavi
2025-10-08 14:21:23 -07:00
committed by GitHub
parent 8d8a2ab64e
commit 741b57ed06
6 changed files with 41 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/core/src/ide/ide-installer.test.ts
+18 -1
View File
@@ -119,7 +119,24 @@ describe('ide-installer', () => {
'google.gemini-cli-vscode-ide-companion',
'--force',
],
{ stdio: 'pipe' },
{ stdio: 'pipe', shell: false },
);
});
it('installs the extension using code cli on windows', async () => {
const { installer } = setup({
platform: 'win32',
execSync: () => 'C:\\Program Files\\Microsoft VS Code\\bin\\code.cmd',
});
await installer.install();
expect(child_process.spawnSync).toHaveBeenCalledWith(
'C:\\Program Files\\Microsoft VS Code\\bin\\code.cmd',
[
'--install-extension',
'google.gemini-cli-vscode-ide-companion',
'--force',
],
{ stdio: 'pipe', shell: true },
);
});
packages/core/src/ide/ide-installer.ts
+1 -1
View File
@@ -125,7 +125,7 @@ class VsCodeInstaller implements IdeInstaller {
'google.gemini-cli-vscode-ide-companion',
'--force',
],
{ stdio: 'pipe' },
{ stdio: 'pipe', shell: this.platform === 'win32' },
);
if (result.status !== 0) {